Skip to content

Eliminate legacy flow syntax in ReactNativeFeatureFlags.js #57192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamChou19815 wants to merge 1 commit into from
+5 −6
Closed

Eliminate legacy flow syntax in ReactNativeFeatureFlags.js #57192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ react.runtime=automatic

experimental.deprecated_utilities.excludes=<PROJECT_ROOT>/packages/react-native/Libraries/Renderer/shims/ReactNativeTypes.js
experimental.deprecated_utilities.excludes=<PROJECT_ROOT>/packages/react-native/Libraries/Renderer/shims/ReactNativeViewConfigRegistry.js
experimental.deprecated_utilities.excludes=<PROJECT_ROOT>/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
ban_spread_key_props=true

[lints]
Expand Down
4 changes: 2 additions & 2 deletions ...ges/react-native/scripts/featureflags/templates/js/ReactNativeFeatureFlags.js-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
setOverrides,
} from './ReactNativeFeatureFlagsBase';

export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
export type ReactNativeFeatureFlagsJsOnly = Readonly<{
${Object.entries(definitions.jsOnly)
.map(
([flagName, flagConfig]) =>
Expand All @@ -46,7 +46,7 @@ ${Object.entries(definitions.jsOnly)

export type ReactNativeFeatureFlagsJsOnlyOverrides = OverridesFor<ReactNativeFeatureFlagsJsOnly>;

export type ReactNativeFeatureFlags = $ReadOnly<{
export type ReactNativeFeatureFlags = Readonly<{
...ReactNativeFeatureFlagsJsOnly,
${Object.entries(definitions.common)
.map(
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d9146c8c9b0c602e4cedb99e6d91558e>>
* @generated SignedSource<<609451fd0a38e0f8eaf685e7cf534e27>>
* @flow strict
* @noformat
*/
Expand All @@ -27,7 +27,7 @@ import {
setOverrides,
} from './ReactNativeFeatureFlagsBase';

export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
export type ReactNativeFeatureFlagsJsOnly = Readonly<{
jsOnlyTestFlag: Getter<boolean>,
animatedDeferStartOfTimingAnimations: Getter<boolean>,
animatedShouldDebounceQueueFlush: Getter<boolean>,
Expand All @@ -46,7 +46,7 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{

export type ReactNativeFeatureFlagsJsOnlyOverrides = OverridesFor<ReactNativeFeatureFlagsJsOnly>;

export type ReactNativeFeatureFlags = $ReadOnly<{
export type ReactNativeFeatureFlags = Readonly<{
...ReactNativeFeatureFlagsJsOnly,
commonTestFlag: Getter<boolean>,
commonTestFlagWithoutNativeImplementation: Getter<boolean>,
Expand Down
Loading