RDKEMW-22210 : Test PR Update build_dependencies.sh - #214
Open
balav08 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the dependency bootstrap script used by CI to align with newer RDK Thunder/ThunderTools sources and revised upstream branches, reducing reliance on downstream patching.
Changes:
- Pin ThunderTools/Thunder to specific commit SHAs after cloning the
R4_4-RDKbranch. - Switch
entservices-apisto clone fromdevelopandentservices-testframeworkto2.0.0. - Remove patch application steps previously applied to ThunderTools/Thunder.
Suppressed comments (2)
build_dependencies.sh:47
- Cloning
entservices-apisfrom the movingdevelopbranch makes this build script non-reproducible and can introduce unexpected breakages. Consider pinning to a tag or commit SHA (similar to Thunder/ThunderTools) so CI uses a known-good version.
git clone --branch develop https://github.com/rdkcentral/entservices-apis.git
build_dependencies.sh:71
- After removing the patch steps, the
cd ThunderTools; cd -andcd Thunder; cd -sequences are now no-ops (they change directories and immediately change back). Removing them reduces confusion and avoids accidental reliance on$OLDPWD.
echo "buliding thunderTools"
cd ThunderTools
cd -
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
29
to
51
| rm -rf iarmbus ThunderTools Thunder entservices-apis entservices-testframework gssdp | ||
|
|
||
| THUNDER_TOOLS_COMMIT_SHA="d5dd83c7c19c49c7f25c558c126500bd2d64f7a4" | ||
| THUNDER_COMMIT_SHA="2c0fcc5529e7da734be558ca6efa05d934dcce31" | ||
|
|
||
| git clone https://github.com/rdkcentral/iarmbus.git | ||
| export IARMBUS_PATH=$GITHUB_WORKSPACE/iarmbus | ||
|
|
||
| git clone --branch R4.4.3 https://github.com/rdkcentral/ThunderTools.git | ||
| git clone --branch R4_4-RDK https://github.com/rdkcentral/ThunderTools.git | ||
| cd ThunderTools | ||
| git checkout $THUNDER_TOOLS_COMMIT_SHA | ||
| cd .. | ||
|
|
||
| git clone --branch R4.4.1 https://github.com/rdkcentral/Thunder.git | ||
| git clone --branch R4_4-RDK https://github.com/rdkcentral/Thunder.git | ||
| cd Thunder | ||
| git checkout $THUNDER_COMMIT_SHA | ||
| cd .. | ||
|
|
||
| git clone --branch main https://github.com/rdkcentral/entservices-apis.git | ||
| git clone --branch develop https://github.com/rdkcentral/entservices-apis.git | ||
|
|
||
| git clone https://$GITHUB_TOKEN@github.com/rdkcentral/entservices-testframework.git | ||
| git clone --branch 2.0.0 https://github.com/rdkcentral/entservices-testframework.git | ||
|
|
||
| git clone --branch gssdp-1.2.3 https://gitlab.gnome.org/GNOME/gssdp.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.