Update middleware.inc - #170
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the default IPK feed path used by the middleware machine include, which controls where builds fetch middleware IPKs from.
Changes:
- Changed
MW_IPK_PATHdefault from a release-numbered path to a ticket/debug-specific path.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
49c2c6c to
cbe5a32
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
It hard-codes a ticket-specific debug artifact path as the default feed location, which is likely to break or destabilize consumers expecting the release-based path.
Review details
Suppressed comments (1)
conf/machine/include/middleware.inc:10
- The default
MW_IPK_PATHhas been changed from a release-based path to a ticket-specific debug path (middleware-dbg/RDKEMW-16723-2). This makes the feed location effectively hard-coded to a one-off artifact and no longer aligned withRELEASE_NUM, which can break consumers when the debug artifacts are moved/cleaned up. If a debug feed is needed for a specific build, it should be provided via an override in a local config rather than committed as the default.
MW_IPK_PATH ?= "middleware-dbg/RDKEMW-16723-2"
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The new hardcoded ticket-specific debug artifact path introduces brittle, non-reproducible feed configuration and conflicts with the existing release-number-based convention used elsewhere.
Review details
Suppressed comments (1)
conf/machine/include/middleware.inc:10
MW_IPK_PATHis now hardcoded to a ticket-specific debug artifact path, which makes builds non-reproducible and likely to break once that artifact is pruned; it also becomes inconsistent withoss_mw.inc, which still derives its feed fromRELEASE_NUM. Prefer the release-number-based path (and override it via configuration when a debug feed is intentionally needed).
MW_IPK_PATH ?= "middleware-dbg/RDKEMW-16723-2"
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
No description provided.