Feature/rdkemw 22188 xoeref - #168
Open
dp0000 wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the default middleware IPK feed configuration by changing the release identifier used in feed URLs and switching the base artifact directory from the release feed to the debug feed.
Changes:
- Update
RELEASE_NUMfrom a semantic version to a ticket/build identifier. - Switch middleware and OSS middleware IPK feed base paths from
middleware-rel/...tomiddleware-dbg/....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the default release identifier and the base feed directory used to construct middleware IPK feed URLs. |
| conf/machine/include/oss_mw.inc | Switches the OSS middleware feed base directory used to construct OSS IPK feed URLs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.18" | ||
| RELEASE_NUM = "RDKEMW-22188_xi" |
| RELEASE_NUM = "RDKEMW-22188_xi" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
conf/machine/include/middleware.inc:8
RELEASE_NUMis assigned with=which forces this value even when a build wants to override it (e.g., via distro/machine/local.conf). If this is meant to be a default for the feed path, prefer a weak assignment (?=) to keep builds configurable.
RELEASE_NUM = "RDKEMW-22188_xi"
conf/machine/include/oss_mw.inc:6
MW_OSS_IPK_SERVER_PATHis set with a strong=assignment, unlikeMW_IPK_SERVER_PATHwhich uses?=. Using?=here too would make the OSS feed URL overrideable in machine/distro/local config when needed (e.g., pointing to a mirror).
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.