RDKEMW-20793:Fetching default fpLED brightness from hostdatadefault - #280
Open
DakshayaniMV wants to merge 1 commit into
Open
RDKEMW-20793:Fetching default fpLED brightness from hostdatadefault#280DakshayaniMV wants to merge 1 commit into
DakshayaniMV wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates front-panel LED (fpLED) brightness initialization logic in the device settings RPC server.
Changes:
- Removes the compile-time default brightness override (
dsFPD_BRIGHTNESS_DEFAULT) and its associated migration logic. - Initializes brightness persistence fallback using
dsFPD_BRIGHTNESS_MAX.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
179
to
183
| value = device::HostPersistence::getInstance().getProperty("Power.brightness", numberToString(maxBrightness)); | ||
| _dsPowerBrightness = stringToNumber(value); | ||
|
|
||
| value = device::HostPersistence::getInstance().getProperty("Text.brightness", numberToString(maxBrightness)); | ||
| _dsTextBrightness = stringToNumber(std::move(value)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.