[Thunder] Promote configs/extensionconfigs settings to cmake - #2219
[Thunder] Promote configs/extensionconfigs settings to cmake#2219sebaszm wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new CMake options are not wired into the legacy config-generation path and will have no effect under that build configuration.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates Thunder’s generated runtime configuration to allow configs (plugin configs directory) and extensionconfigs (extension configs directory) to be supplied via CMake, aligning config generation with the existing runtime support for these settings.
Changes:
- Add
configsandextensionconfigsto the Thunder config template so they can be emitted into the generatedconfig.json. - Extend the config-generator parameter whitelist to include the new settings.
- Introduce new CMake cache options (
CONFIG_PATH,EXTENSION_CONFIG_PATH) intended to drive those fields.
File summaries
| File | Description |
|---|---|
| Source/Thunder/Thunder.conf.in | Emits configs and extensionconfigs values into the generated config. |
| Source/Thunder/params.config | Whitelists configs and extensionconfigs for config generation. |
| Source/Thunder/GenericConfig.cmake | Adds CMake cache options intended to feed the new config fields. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The template currently always emits configs/extensionconfigs (potentially as empty strings), creating generator/version-dependent output compared to the legacy CMake path which omits them when unset.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
No description provided.