-
Notifications
You must be signed in to change notification settings - Fork 45
feat(sdk): guard the delete organization flow #1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whoAbhishekSah
wants to merge
4
commits into
main
Choose a base branch
from
sdk-org-delete-guards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dd2081b
feat(sdk): guard the delete organization flow
whoAbhishekSah d8b1b73
fix(sdk): review fixes for the delete organization guards
whoAbhishekSah cfd992e
feat(sdk): drive the delete button from CheckOrganizationDelete
whoAbhishekSah 3ac4b9d
fix(sdk): say please in the delete blocker instructions
whoAbhishekSah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { create } from '@bufbuild/protobuf'; | ||
| import { RQLFilterSchema } from '@raystack/proton/frontier'; | ||
| import { INVOICE_STATES } from './constants'; | ||
|
|
||
| // The one definition of "an invoice the customer still has to pay": open | ||
| // state with a non-zero amount. The server refuses an organization delete | ||
| // while any exist, and the billing page's payment-issue banner keys off the | ||
| // same set — both build their queries from these filters so the two can not | ||
| // drift apart. | ||
| export function openInvoiceFilters() { | ||
| return [ | ||
| create(RQLFilterSchema, { | ||
| name: 'state', | ||
| operator: 'eq', | ||
| value: { case: 'stringValue', value: INVOICE_STATES.OPEN } | ||
| }), | ||
| create(RQLFilterSchema, { | ||
| name: 'amount', | ||
| operator: 'gt', | ||
| value: { case: 'numberValue', value: 0 } | ||
| }) | ||
| ]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: raystack/frontier
Length of output: 882
🏁 Script executed:
Repository: raystack/frontier
Length of output: 41441
🏁 Script executed:
Repository: raystack/frontier
Length of output: 50373
🏁 Script executed:
Repository: raystack/frontier
Length of output: 44836
Disable deletion during balance refetches.
isLoadingis false when cached data exists during a background refetch. ExposeisFetchingfromuseTokensand include it in the delete-button guard. Add a regression test for reopening the dialog after the balance changes from zero to positive.