-
Notifications
You must be signed in to change notification settings - Fork 3
Species map trip dates frequency view #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nleiby
wants to merge
11
commits into
rawcomposition:main
Choose a base branch
from
nleiby:up/species-map-frequency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5a33d47
Add a trip-dates mode to the species map
nickleiby a9ac7ac
Add a toggle to hide personal locations on the species map
nickleiby 3901459
Move species map controls left and make the info card dismissible
nickleiby a9456dd
Add a saved-hotspots-only toggle to the species map
nickleiby 9a9b92e
Render saved hotspots as markers on the species map
nickleiby 8ea4111
Fix marker clicks and rework species map chrome
nickleiby a24f3f4
Spread the frequency scale across real data
nickleiby b2605a5
Reset the saved-hotspots filter when the map reopens
nickleiby 406133d
Fix dead styling branches and filter scope on the species map
nickleiby 77ba07e
Fade saved hotspots with no data for the current view
nickleiby 6145a76
Stop drawing a halo over saved hotspot markers
nickleiby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { useQuery } from "@tanstack/react-query"; | ||
| import { OPENBIRDING_API_URL } from "lib/config"; | ||
| import { getMonthRange } from "lib/targets"; | ||
| import { useTrip } from "hooks/useTrip"; | ||
| import type { OpenBirdingHotspotRankingResponse } from "@birdplan/shared"; | ||
|
|
||
| const HOTSPOT_LIMIT = 500; | ||
|
|
||
| export default function useSpeciesHotspotRankings(code?: string, locationIds?: string[]) { | ||
| const { trip } = useTrip(); | ||
| const months = trip ? getMonthRange(trip.startMonth, trip.endMonth) : []; | ||
| const scope = locationIds ? locationIds.join(",") : trip?.region; | ||
|
|
||
| const { data } = useQuery<OpenBirdingHotspotRankingResponse>({ | ||
| queryKey: ["openbirding-trip-hotspots", code, scope, months.join(",")], | ||
| queryFn: async () => { | ||
| const res = await fetch(`${OPENBIRDING_API_URL}/api/v1/hotspots/species/${code}`, { | ||
| method: "POST", | ||
| headers: { "Content-Type": "application/json" }, | ||
| body: JSON.stringify({ | ||
| ...(locationIds ? { locationIds } : { region: trip?.region, limit: HOTSPOT_LIMIT }), | ||
| months, | ||
| sortBy: "best", | ||
| }), | ||
| }); | ||
| if (!res.ok) throw new Error("Failed to fetch hotspot rankings"); | ||
| return res.json(); | ||
| }, | ||
| enabled: !!code && !!OPENBIRDING_API_URL && (locationIds ? locationIds.length > 0 : !!trip?.region), | ||
| staleTime: 24 * 60 * 60 * 1000, | ||
| refetchOnWindowFocus: false, | ||
| }); | ||
|
|
||
| return data?.items ?? []; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting by frequency seems to return less useful results: 100% of 19 checklists seems less useful for planning than 85% of 500. The species detail page also seems to default to it, so this makes the map agree with the list.