Skip to content

Register dependency tracker - #621

Closed
etiennebarrie wants to merge 2 commits into
rails:mainfrom
etiennebarrie:register-dependency-tracker
Closed

Register dependency tracker#621
etiennebarrie wants to merge 2 commits into
rails:mainfrom
etiennebarrie:register-dependency-tracker

Conversation

@etiennebarrie

@etiennebarrie etiennebarrie commented Jul 31, 2026

Copy link
Copy Markdown

While working on the dependency tracker in Rails (rails/rails#57948) I realized Jbuilder wasn't registering its dependency tracker (from #504). This just plugs it in.

$ cat app/views/root/index.json.jbuilder 
json.partial! "root/greeting"
$ cat app/views/root/_greeting.json.jbuilder 
json.greeting "greeting v1"

Before:

bin/rails runner '
finder = ApplicationController.new.lookup_context
finder.formats = [:json]
template = finder.find("root/index")
p ActionView::DependencyTracker.find_dependencies(template.virtual_path, template, finder.view_paths)'
[]

After:

bin/rails runner '
finder = ApplicationController.new.lookup_context
finder.formats = [:json]
template = finder.find("root/index")
p ActionView::DependencyTracker.find_dependencies(template.virtual_path, template, finder.view_paths)'

I also made sure wildcards are supported by adding Jbuilder::DependencyTracker.supports_view_paths?.

@etiennebarrie

Copy link
Copy Markdown
Author

Sorry I just saw #620 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant