Repository navigation
fix(download): link completed downloads by resource ID - #559
Merged
Alruinous merged 1 commit intoNov 5, 2026
Merged
Conversation
Resolve the destination from storage path and resource type so same-name resources cannot redirect download details to another card. Closes raids-lab#558 Signed-off-by: Jinghao-coding <jeffery_06@163.com>
Jinghao-coding
marked this pull request as ready for review
November 3, 2026 15:58
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Alruinous
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix completed model/dataset downloads opening a different resource with the same name.
Changes
resourceIdin download details using the stored download path and resource type, matching resource publication. Existing and renamed resources work without a database migration; missing/deleted resources produce no link.Testing
AI:
make fmt pre-commit-check buildandgo vet ./internal/handler: passed.make pre-commit-check build: passed.11; the fix opened resource42for models and datasets. Both categories hid the button whenresourceIdwas absent, even with same-name resources cached.git diff --check: passed.Compatibility and deployment
resourceIdis optional and used by the frontend; CLI download decoding, commands, and output are unchanged. Backend/CLIAPIVersionremain 4; backendMinSupportedCLIAPIVersionand CLIMinSupportedBackendAPIVersioneach remain 3. Chart configuration andversion/appVersionremain unchanged at1.5.0. Deploy the backend before the frontend so the ID is available immediately.修复模型、数据集下载完成后,资源卡片可能跳转到另一条同名资源的问题。
修改
resourceId,与资源发布时的标识规则一致。兼容已有记录和资源重命名,无需数据库迁移;资源不存在或已删除时不返回跳转目标。测试
AI:
make fmt pre-commit-check build、go vet ./internal/handler:通过。make pre-commit-check build:通过。11,修复后模型、数据集均跳到指定资源42;未返回resourceId时,两类页面均隐藏按钮,即使缓存中仍有同名资源。git diff --check:通过。兼容性与部署
resourceId为前端使用的可选字段,CLI 下载接口解码、命令及输出保持不变。后端、CLI 的APIVersion均保持 4;后端MinSupportedCLIAPIVersion、CLIMinSupportedBackendAPIVersion均保持 3。Chart 配置及version/appVersion保持1.5.0。先部署后端,再部署前端,使跳转 ID 立即可用。Closes #558