Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Display class name on gesture recognition demo - #101

Merged
corneliusboehm merged 16 commits into
masterfrom
display_class_name_on_gesture_demo
Feb 5, 2021
Merged

corneliusboehm merged 16 commits into
masterfrom
display_class_name_on_gesture_demo

Conversation

@nahuakang

Copy link
Copy Markdown
Contributor

This PR is a follow-up ticket to PR84 and uses DisplayClassNameOverlay in the run_gesture_recognition.py script.

The PR also introduces a new private method: DisplayClassnameOverlay._adjust_font_scale to automatically re-scale the font_scale instance variable should the text width be larger than the frame width.

@nahuakang
nahuakang marked this pull request as ready for review February 1, 2021 13:31
@nahuakang nahuakang changed the title (WIP) Display class name on gesture recognition demo Display class name on gesture recognition demo Feb 1, 2021

@corneliusboehm corneliusboehm left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tuning and testing already, and thanks for adding the font scale check 👍

Comment thread sense/display.py Outdated
Comment thread tests/test_display.py
Comment thread examples/run_gesture_recognition.py Outdated
"Swiping down": .4,
"Swiping down (with two hands)": .5,
"Swiping left": .5,
"Swiping right": .5,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Swiping left and right is also mixed up (same as pointing left/right)

Comment thread sense/downstream_tasks/gesture_recognition/__init__.py
Comment thread sense/downstream_tasks/gesture_recognition/__init__.py
Comment thread examples/run_gesture_recognition.py Outdated
Comment thread sense/display.py Outdated
Comment thread tests/test_display.py Outdated
Comment thread tests/test_display.py Outdated
Comment thread tests/test_display.py Outdated
Comment thread tests/test_display.py Outdated
Comment thread examples/run_gesture_recognition.py Outdated
Comment thread sense/display.py
Comment thread tests/test_display.py
Comment thread tests/test_display.py Outdated
Comment thread tests/test_display.py Outdated

@corneliusboehm corneliusboehm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📛

@corneliusboehm
corneliusboehm merged commit 6a75d3d into master Feb 5, 2021
@corneliusboehm
corneliusboehm deleted the display_class_name_on_gesture_demo branch February 5, 2021 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants