fix: Apply extension-contributed project metadata in quarto preview - #14784
Open
mcanouil wants to merge 1 commit into
Open
fix: Apply extension-contributed project metadata in quarto preview#14784mcanouil wants to merge 1 commit into
mcanouil wants to merge 1 commit into
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mcanouil
force-pushed
the
fix/issue14783
branch
from
August 18, 2026 09:36
7850d24 to
1f66ae3
Compare
mcanouil
force-pushed
the
fix/issue14783
branch
2 times, most recently
from
August 18, 2026 10:00
2e7d315 to
612d99a
Compare
mcanouil
marked this pull request as ready for review
August 18, 2026 12:09
Project metadata contributed by an extension through contributes.metadata.project, such as brand, was applied only on the render path. The preview command builds the project context before the render services exist, so the contribution never reached the project configuration and the brand was ignored. The merge now runs in every project context, with a fresh extension context when the render options are absent. Invalid contributed metadata stays fatal for a render, and becomes a warning that names the extension elsewhere, so preview, inspect, publish and serve keep working. Fixes quarto-dev#14783
mcanouil
force-pushed
the
fix/issue14783
branch
from
August 18, 2026 12:10
612d99a to
253ac05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14783.
Project metadata contributed by an extension through
contributes.metadata.project, such asbrand, was applied on the render path only.The preview command builds the project context before the render services exist, so the contribution never reached the project configuration.
The merge now runs for every project context, with a fresh extension context when the render options are absent.
f6a0f89 made that same move for engine extensions in #14208, and left the metadata merge behind the gate with the note that it needs the render options.
The merge in fact uses
services.extensiononly, so this change completes that work instead of taking a different route to it.Invalid contributed metadata stays fatal for a render, and becomes a warning that names the extension elsewhere, so a faulty extension cannot stop
quarto preview,quarto inspect,quarto publishorquarto serve.Every command that builds a project context applies the metadata now, so
quarto inspectreports it as well.The new tests build the context the way preview does, without render options, and cover the brand for a single file and for a project, the render path, a contributed
output-dir, and a faulty extension.Run locally with the brand, extension, project and inspect tests, 55 tests, all correct.