fix: fix Google Analytics gtag - #51
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the window.gtag shim so it records commands into dataLayer in the same shape as Google Analytics’ recommended snippet (pushing a real arguments object), which is required for gtag.js to correctly process commands like config and consent.
Changes:
- Update
ensureGtag()to implementgtagas a normal function and push the genuineargumentsobject todataLayer. - Adjust tests/helpers to normalize
dataLayerentries (includingArguments) into plain arrays for assertions. - Add a test assertion verifying the
dataLayerentry is[object Arguments].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| documentation-ui/src/custom/docs/components/analytics/consent-mode.ts | Switches gtag shim to push a real arguments object so GA command processing works correctly. |
| documentation-ui/src/custom/docs/components/analytics/consent-mode.test.ts | Updates assertions/helpers to handle Arguments entries and verifies the correct entry type is recorded. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.