fix: fix next/image type error and remove @next/third-parties - #50
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates workspace dependencies and adjusts the TripleCard image-component prop typing to resolve a next/image assignability/type mismatch, while also removing the unused @next/third-parties dependency from the Sphinx React package.
Changes:
- Remove
@next/third-partiesfromsphinx-ui/reactand bump several build/dev dependencies (e.g.,postcss,prettier,autoprefixer,@quantinuum/quantinuum-ui). - Refine
TripleCardImagePropssosrcis explicitlystring, keepingnext/imagecomponents assignable as theimageComponent. - Bump tooling dependencies in
documentation-ui(Storybook, ESLint, PostCSS, semantic-release, typescript-eslint).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sphinx-ui/react/package.json | Removes @next/third-parties and updates Sphinx React package dependencies. |
| documentation-ui/src/custom/docs/components/triplecard/index.tsx | Fixes next/image compatibility by narrowing src in TripleCardImageProps to string. |
| documentation-ui/package.json | Updates development/tooling dependencies (Storybook, ESLint, PostCSS, release tooling). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sburton84
marked this pull request as ready for review
July 28, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.