QCLINUX: arm64: dts: qcom: added ife lite cpas to purwa camera dtsi

[michael-jihan-qcom]

Added IFE Lite nodes to CPAS to enable proper voting on these paths.

CRs-Fixed: 4561319

[qlijarvis]

PR #660 — validate-patch

PR: #660

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #660 - QCLINUX: arm64: dts: qcom: added ife lite cpas to purwa camera dtsi
Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only commit (QCLINUX: prefix)
Body preserves rationale	✅	Explains purpose: enable proper voting on IFE Lite paths
Fixes tag present/correct	N/A	New feature addition, no bug fix
Authorship preserved	✅	Ignatius Michael Jihan mignatiu@qti.qualcomm.com
Backport note (if applicable)	N/A	Vendor-only commit, not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/purwa-camera.dtsi	✅	Adds IFE1/IFE2 Lite nodes, renumbers cell-index, renames rt-cdm2→rt-cdm1, rt-cdm3→rt-cdm2 consistently

Verdict

Merge as-is. This is a well-formed vendor-only device tree change that adds IFE Lite CPAS nodes for proper bandwidth voting. The diff is internally consistent with correct cell-index renumbering and device node renaming throughout.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

[qlijarvis]

PR #660 — checker-log-analyzer

PR: #660
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27001143420

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no changes in Documentation/devicetree/bindings
dtb-check	❌	Schema validation failures for rt-cdm nodes
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	Subject prefix violation
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #660 - QCLINUX: arm64: dts: qcom: added ife lite cpas to purwa camera dtsi
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27001143420

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no changes in Documentation/devicetree/bindings
dtb-check	❌	Schema validation failures for rt-cdm nodes
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	Subject prefix violation
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable for this branch

---

❌ check-patch-compliance

Root cause: Commit subject uses QCLINUX: prefix which is not a recognized upstream-style prefix.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: added ife lite cpas to purwa camera dtsi
Commit summary does not start with a required prefix

Fix: Update the commit subject to use a proper subsystem prefix. For device tree changes to Qualcomm ARM64 platforms, use:

arm64: dts: qcom: purwa: add ife lite cpas to camera dtsi

The QCLINUX: prefix is a Qualcomm-internal convention and should be removed for commits that follow upstream kernel style. Also note:

• Use lowercase "add" instead of "added" (imperative mood)
• Include the platform name (purwa) for clarity

Reproduce locally:

cd kernel
git log --oneline -1 7ee57354d338
# Check if subject starts with UPSTREAM:, FROMLIST:, BACKPORT:, or a valid subsystem prefix

---

❌ dtb-check

Root cause: The renamed rt-cdm nodes (rt-cdm1 and rt-cdm2) fail schema validation because the compatible string qcom,cam-rt-cdm2_1 doesn't match any registered device tree binding schema.

Failure details:

arch/arm64/boot/dts/qcom/purwa-camx-el2.dtb: /soc@0/qcom,rt-cdm2@acfa000: failed to match any schema with compatible: ['qcom,cam-rt-cdm2_1']
arch/arm64/boot/dts/qcom/purwa-camx-el2.dtb: /soc@0/qcom,rt-cdm1@acf9000: failed to match any schema with compatible: ['qcom,cam-rt-cdm2_1']
arch/arm64/boot/dts/qcom/purwa-evk-camx.dtb: /soc@0/qcom,rt-cdm2@acfa000: failed to match any schema with compatible: ['qcom,cam-rt-cdm2_1']
arch/arm64/boot/dts/qcom/purwa-evk-camx.dtb: /soc@0/qcom,rt-cdm1@acf9000: failed to match any schema with compatible: ['qcom,cam-rt-cdm2_1']

Additionally, there are pre-existing warnings about:

• reg_format issues (invalid reg property lengths)
• avoid_default_addr_size warnings (missing #address-cells/#size-cells)
• interrupts_property warnings (missing interrupt-parent)

Fix:

The schema validation failure is not introduced by this PR — it's a pre-existing issue with the qcom,cam-rt-cdm2_1 compatible string lacking a binding schema in Documentation/devicetree/bindings/. This PR only renames the nodes from rt-cdm2/rt-cdm3 to rt-cdm1/rt-cdm2, which doesn't change the validation outcome.

Options:

1. Accept as-is (recommended for this PR): The dtb-check failure is pre-existing and not caused by this change. The renaming is a refactoring that maintains consistency with the CPAS client-names list.
2. Add a binding schema (separate effort): Create Documentation/devicetree/bindings/media/qcom,cam-rt-cdm.yaml to document the qcom,cam-rt-cdm2_1 compatible string.

Reproduce locally:

cd kernel
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
# Look for purwa-camx-el2.dtb and purwa-evk-camx.dtb errors

---

Verdict

2 blockers to fix:

1. check-patch-compliance (blocker): Change subject from QCLINUX: arm64: dts: qcom: added ife lite cpas to purwa camera dtsi to arm64: dts: qcom: purwa: add ife lite cpas to camera dtsi

2. dtb-check (pre-existing, not a blocker for this PR): The schema validation failure for qcom,cam-rt-cdm2_1 existed before this PR. This change only renames nodes and doesn't introduce new validation issues. Consider adding a device tree binding schema in a follow-up patch, but this should not block the current PR.

Recommendation: Fix the commit subject prefix, then the PR is ready to merge. The dtb-check failure is cosmetic and pre-existing.

[cjha01]

LGTM

[qcomlnxci]

Test jobs on 7ee5735

• Job 119098 on lemans-evk
• Job 119097 on monaco-evk
• Job 119096 on qcs615-ride
• Job 119094 on qcs6490-rb3gen2
• Job 119092 on qcs8300-ride
• Job 119093 on qcs9100-ride-r3
• Job 119095 on x1e80100-crd

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	◻️	◻️	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	◻️	◻️	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	◻️	◻️	✅ Pass	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	◻️	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	◻️	◻️	❌ Fail	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	◻️	◻️	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	◻️	◻️	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	◻️	◻️	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	◻️	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	◻️	◻️	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	◻️

[shashim-quic]

QCLINUX: arm64: dts: qcom: added ife lite cpas to purwa camera dtsi

use imperative, s/added/add

Added IFE Lite nodes to CPAS to enable proper voting on these
paths.

Can you describe it more in your commit log. What is there currently which causes and how proposed changes address it.