PENDING: arm64: dts: qcom: talos-evk: add QPS615 m.2 ethernet staging overlay

[ayaan-anwar]

Add talos-evk-staging.dtso for the QPS615 m.2 e-key daughter card. When installed, the QPS615 PCIe switch replaces the direct WCN7850 WLAN connection at pcie_port0. The overlay:

• Enables PCIe with IOMMU mappings (required by QPS615 DMA traffic)
• Disables the direct WCN7850 WLAN at pcie_port0 (wifi@0)
• Moves WLAN to QPS615 downstream port 1 (pcie@1,0, bus 3 dev 0)
• Describes dual Ethernet (TC956X) at QPS615 downstream port 3 (pci@3,0, bus 5 dev 0 fn0/fn1)

CRs-Fixed: 4561210
QLIJIRA: 104
QLI 0.0 PR: qualcomm-linux/kernel-topics#1314

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4561210 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4561210
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #659 — validate-patch

PR: #659

Verdict	Issues	Detailed Report
⚠️	5	Full report

Final Summary

1. Lore link present: No — PENDING: prefix; no lore link provided or expected for staging content
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — PENDING: prefix indicates patch is not yet posted to mailing lists
4. PR present in qcom-next: Not checked — PENDING: staging overlay, likely vendor-tree only

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #659 - arm64: dts: qcom: talos-evk: add QPS615 m.2 ethernet staging overlay
Upstream commit: N/A (PENDING: prefix indicates not yet posted)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	PENDING: prefix; not yet upstream
Body preserves rationale	✅	Clear description of QPS615 PCIe switch topology and overlay purpose
Fixes tag present/correct	N/A	New feature, no Fixes tag expected
Authorship preserved	✅	Author: Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable)	N/A	New staging overlay, not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/Makefile	✅	Adds talos-evk-staging.dtbo build target between existing staging overlays
arch/arm64/boot/dts/qcom/talos-evk-staging.dtso	⚠️	New staging overlay; see issues below

Issues

Commit Message:

• PENDING: prefix present — Indicates patch is not yet posted upstream. This is acceptable for staging/vendor-specific content, but the commit message should clarify whether this is intended for upstream submission or is vendor-only.

Devicetree Overlay Content:

• Nested node structure concern — The overlay places pcie@1,0 and pci@3,0 as children of wifi@0 (which is being disabled). This is unusual; typically when disabling a node, you wouldn't add children to it. The intended structure may be to place these as siblings of wifi@0 under &pcie_port0, not as children of the disabled wifi@0 node.
• Self-referencing GPIO — qps615: pci@0,0 defines itself as a gpio-controller and then immediately references itself via phy-reset-gpios = <&qps615 0 GPIO_ACTIVE_LOW>. This creates a circular dependency that may not work as intended during device probe.
• Missing compatible strings — The TC956X Ethernet devices at pci@0,0 and pci@0,1 under pci@3,0 lack compatible properties, which are typically required for PCI device binding in devicetree.

Makefile:

• Placement — The new entry is inserted between talos-staging.dtbo and kodiak-staging.dtbo, which is reasonable for grouping staging overlays, but breaks strict alphabetical ordering if that was the convention.

Verdict

Needs revision — The devicetree node hierarchy appears incorrect (children under a disabled node), and the self-referencing GPIO controller pattern needs clarification or correction before merge.

Final Summary

1. Lore link present: No — PENDING: prefix; no lore link provided or expected for staging content
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — PENDING: prefix indicates patch is not yet posted to mailing lists
4. PR present in qcom-next: Not checked — PENDING: staging overlay, likely vendor-tree only

[qlijarvis]

PR #659 — checker-log-analyzer

PR: #659
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27000438101

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	DTC warnings: reg/ranges format errors in PCIe overlay
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation: PENDING: not allowed
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable (PENDING: prefix)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #659 - PENDING: arm64: dts: qcom: talos-evk: add QPS615 m.2 ethernet staging overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27000438101

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	DTC warnings: reg/ranges format errors in PCIe overlay
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation: PENDING: not allowed
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable (PENDING: prefix)

---

❌ check-patch-compliance

Root cause: Commit subject starts with PENDING: prefix, which is not in the allowed list of prefixes.

Failure details:

2026-06-05T07:13:35.6668334Z Checking commit: PENDING: arm64: dts: qcom: talos-evk: add QPS615 m.2 ethernet staging overlay
2026-06-05T07:13:35.6682851Z Commit summary does not start with a required prefix

Fix: Remove the PENDING: prefix from the commit subject. The subject should start with the subsystem prefix directly:

arm64: dts: qcom: talos-evk: add QPS615 m.2 ethernet staging overlay

Reproduce locally:

git log -1 --format=%s HEAD | grep -E '^(UPSTREAM:|FROMLIST:|BACKPORT:|arm64:|drivers:|dt-bindings:)'

---

❌ dtb-check

Root cause: PCIe device tree overlay has incorrect #address-cells and #size-cells inheritance, causing reg and ranges property format mismatches.

Failure details:

talos-evk-staging.dtso:39.4-36: Warning (reg_format): /fragment@1/__overlay__/wifi@0/pcie@1,0:reg: 
  property has invalid length (20 bytes) (#address-cells == 2, #size-cells == 1)

talos-evk-staging.dtso:65.4-36: Warning (reg_format): /fragment@1/__overlay__/wifi@0/pci@3,0:reg: 
  property has invalid length (20 bytes) (#address-cells == 2, #size-cells == 1)

talos-evk-staging.dtso:43.4-11: Warning (ranges_format): /fragment@1/__overlay__/wifi@0/pcie@1,0:ranges: 
  empty "ranges" property but its #address-cells (3) differs from /fragment@1/__overlay__/wifi@0 (2)

talos-evk-staging.dtso:43.4-11: Warning (ranges_format): /fragment@1/__overlay__/wifi@0/pcie@1,0:ranges: 
  empty "ranges" property but its #size-cells (2) differs from /fragment@1/__overlay__/wifi@0 (1)

talos-evk-staging.dtso:69.4-11: Warning (ranges_format): /fragment@1/__overlay__/wifi@0/pci@3,0:ranges: 
  empty "ranges" property but its #address-cells (3) differs from /fragment@1/__overlay__/wifi@0 (2)

talos-evk-staging.dtso:69.4-11: Warning (ranges_format): /fragment@1/__overlay__/wifi@0/pci@3,0:ranges: 
  empty "ranges" property but its #size-cells (2) differs from /fragment@1/__overlay__/wifi@0 (1)

talos-evk-staging.dtso:38.12-62.5: Warning (avoid_default_addr_size): /fragment@1/__overlay__/wifi@0/pcie@1,0: 
  Relying on default #address-cells value

talos-evk-staging.dtso:38.12-62.5: Warning (avoid_default_addr_size): /fragment@1/__overlay__/wifi@0/pcie@1,0: 
  Relying on default #size-cells value

talos-evk-staging.dtso:64.11-97.5: Warning (avoid_default_addr_size): /fragment@1/__overlay__/wifi@0/pci@3,0: 
  Relying on default #address-cells value

talos-evk-staging.dtso:64.11-97.5: Warning (avoid_default_addr_size): /fragment@1/__overlay__/wifi@0/pci@3,0: 
  Relying on default #size-cells value

Fix: The PCIe child nodes (pcie@1,0 and pci@3,0) are nested under wifi@0 which has PCIe address format (#address-cells = 2, #size-cells = 1), but PCIe bridges require standard PCIe addressing (#address-cells = 3, #size-cells = 2). The reg properties are using 5-cell format (standard PCIe) but the parent expects 3-cell format.

Solution: The overlay structure needs to be corrected. The pcie@1,0 and pci@3,0 nodes should not be nested under wifi@0. Instead, they should be direct children of &pcie_port0 or the overlay should properly override the parent node's address/size cells. Review the PCIe topology and ensure the device tree hierarchy matches the actual hardware bus structure.

Reproduce locally:

# In kernel source tree after applying the patch:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs W=1 2>&1 | grep talos-evk-staging

---

Verdict

2 blockers must be fixed before merge:

1. check-patch-compliance: Remove PENDING: prefix from commit subject
2. dtb-check: Fix PCIe device tree overlay structure to resolve reg/ranges format warnings

The dtb-check failures indicate a structural issue with how the PCIe switch topology is described in the overlay. The nesting of PCIe bridge nodes under the wifi@0 node creates address cell mismatches. This needs architectural review to ensure the device tree accurately represents the QPS615 PCIe switch hierarchy.