Repository navigation
Fix binary decoding into reused decimal receivers - #48
Closed
ryanduguid wants to merge 1 commit into
Closed
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix silent coefficient retention when
UnmarshalBinaryreuses a decimal receiver. A valid padded input can give1.23a big-integer representation; decoding-4.56into that receiver then returns-1.23without an error. Sequential gob decoding exposes the same receiver-state defect.Both decoder helpers now replace the complete coefficient through the existing constructors. This clears inactive storage while preserving copied values, sign, precision and the binary format.
Evidence
make fuzz-all 20in an integration run using only PR Fix division panics from oversized trial quotients #47's published division helper as an overlay.Risk
Previously retained coefficients now become the incoming value. The big path still allocates a fresh integer so copied decimals remain immutable. Existing validation and malformed-input behaviour remain.
Unverified
Upstream Test and Fuzz are waiting for approval. The full fuzz run on this branch alone stops at the separate division panic fixed by #47. Full lint and the 386 suite have the same failures as master. Native Windows race tests (no
gcc), macOS and timing were not checked.