Repository navigation
Replace the two rebuild thread parameters in the tab completion by rebuild-index-max-num-threads - #365
Merged
Conversation
…ebuild-index-max-num-threads` The tab completion of `qlever settings` and of `--set-runtime-parameters` for `qlever start` offers the runtime parameters from a list in `qleverfile.py`. ad-freiburg/qlever#3875 replaced `rebuild-index-scan-num-threads` and `rebuild-permutation-writer-num-threads` by the single `rebuild-index-max-num-threads`, which limits the threads of a runtime index rebuild as a whole. This change updates the list accordingly and also drops `sort-estimate-cancellation-factor`, which ad-freiburg/qlever#3749 removed. The rename of `sparql-results-json-with-time` is in #362.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the runtime-parameter completion update.
No open issues 🎉
What changed in this PR
Updates QLever’s runtime-parameter completion list to match upstream changes for qlever settings and qlever start --set-runtime-parameters.
Changes:
- Replaces the two rebuild-thread parameters with
rebuild-index-max-num-threads. - Removes the obsolete
sort-estimate-cancellation-factorparameter. - Leaves the
sparql-results-json-with-timerename to PR #362.
| File | Description |
|---|---|
src/qlever/qleverfile.py |
Updates runtime-parameter names offered by tab completion. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab completion of
qlever settingsand of--set-runtime-parametersforqlever startoffers the runtime parameters from a list inqleverfile.py. ad-freiburg/qlever#3875 replacedrebuild-index-scan-num-threadsandrebuild-permutation-writer-num-threadsby the singlerebuild-index-max-num-threads, which limits the threads of a runtime index rebuild as a whole. This change updates the list accordingly and also dropssort-estimate-cancellation-factor, which ad-freiburg/qlever#3749 removed. The rename ofsparql-results-json-with-timeis in #362.