Repository navigation
Add type annotations to project.py - #933
Merged
Merged
Conversation
And also add typing information.
… Project These functions depends on Project.root attribute, which only exists in Project anyway. They do not make sense in NoProject or _Project. Also add type annotations.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 95.41% 95.41% -0.01%
==========================================
Files 134 134
Lines 26784 26802 +18
==========================================
+ Hits 25557 25574 +17
- Misses 1227 1228 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lieryan
changed the title
lieryan
changed the title
lieryan
force-pushed
the
lieryan-annotate-projectpy
branch
3 times, most recently
from
November 5, 2026 16:48
71ebc78 to
0b6cbb4
Compare
lieryan
force-pushed
the
lieryan-annotate-projectpy
branch
from
November 5, 2026 16:58
0b6cbb4 to
6c3f8b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added type annotations to rope/base/project.py
Checklist (delete if not relevant):