Repository navigation
feat(pre-commit): add Codecov config schema and pre-commit hook - #598
Conversation
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
Sorry that review took so long here -- I've been on a tight schedule lately for FOSS work.
I have one thing I want to clarify before accepting, but the change looks well-formed. Thanks again for all of these new schemas and hooks!
| "hook_config": { | ||
| "name": "Validate Codecov config", | ||
| "files": [ | ||
| r"^((\.github|dev)/)?\.?codecov\.ya?ml$", |
There was a problem hiding this comment.
Can you give me a pointer to codecov docs for this which indicate that .github/codecov.yaml is supported?
The reason I raise this is that I prefer to follow the lead of SchemaStore whenever possible (i.e. as long as we don't have reason to believe that SchemaStore is wrong). It makes for a much simpler policy around the file paths.
SchemaStore currently lists only codecov.yml and .codecov.yml in the repo root. If that's wrong, I can accept this PR and work on upstreaming the improvement there (or you can give them a PR if you like -- I've always found them very friendly!).
There was a problem hiding this comment.
https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml
Please submit a PR to the upstream; I don’t intend to submit one.
There was a problem hiding this comment.
Awesome, thanks! I'll make sure your work finds its way up into SchemaStore.
2 participants
No description provided.