Repository navigation
馃И test(seed): verify periodic update scheduling - #3384
Merged
gaborbernat merged 2 commits intoOct 9, 2026
Merged
Conversation
test_periodic_update_skip and test_periodic_update_trigger called periodic_update(..., os.environ, True), but the last two parameters are do_periodic_update and then env. So do_periodic_update got os.environ and env got True. Both tests still passed because os.environ is truthy, and trigger_update is mocked, so nothing noticed that the mock received env=True. Put the arguments in the right order and check that the trigger test hands os.environ through to trigger_update. With the old order, or with handle_auto_update dropping env on the floor, that test now fails.
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3383. The periodic-update checks passed
os.environasdo_periodic_updateandTrueasenv. A truthy environment enabled scheduling, while a mocked update launcher hid the invalidenvvalue.Use named arguments for the update flag and environment. Exercise scheduling with isolated app-data storage and mock subprocess creation; check the saved log and a single launch. Empty and custom environments cover environment forwarding through the inline-update setting.