Repository navigation
ci(release-proposal): do not propose from a superseded commit - #1560
Open
RonnyPfannschmidt wants to merge 1 commit into
Open
RonnyPfannschmidt wants to merge 1 commit into
RonnyPfannschmidt wants to merge 1 commit into
Conversation
Merging pypa#1553 and then pypa#1557 48 seconds apart raced: the proposal run for pypa#1553's merge commit still saw the 2.6.0 fragment, force-pushed release/main three seconds after pypa#1557 was merged, found no open release PR and opened pypa#1558, a duplicate of the release that had just shipped. Merging it would have re-run the 2.6.0 tagging. The push step now stops when the source branch no longer points at the run's commit; the run for the newer commit proposes the release. A push that finds no fragments in either package closes any release PR still open for its branch, unless the branch has moved on, so a duplicate that slips through anyway does not linger. Co-Authored-By: Claude Opus 5.5 via Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude Opus 5.5 via Claude Code for the setuptools-scm maintainers; I prompted it, it did the work, I read it.
#1558 was a duplicate release PR for vcs-versioning 2.6.0, opened after #1557 had already released it. Merging #1553 and #1557 48 seconds apart raced:
1556.feature.mdfragment is still there, so it plans 2.6.0release/main, finds no open release PR and opens #1558Merging #1558 would have re-run the 2.6.0 tagging, which since #1553 refuses a tag at another commit and opens a "did not start" issue.
create-release-prchecks that the source branch still points at the run's commit right before pushing; if not, it stops with a notice and the run for the newer commit proposes the release.close-stale-release-prjob: a push that finds no fragments in either package closes any openrelease/<branch>PR with a comment, unless the branch has moved on, so an older run cannot close a PR a newer commit's run just opened.A concurrency group alone would not have prevented this: the race fit inside the 12-second
create-release-prjob.The agent ran the close script against a mocked Octokit (stale PR closed, no PR, superseded run leaves it alone) and the push guard against a local git remote (current commit pushes, superseded commit does not); neither has run on GitHub yet.