Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pyproject.toml specification says, for
[project.entry-points]:StandardMetadata.from_pyproject()currently accepts both groups and returns them inentrypoints:A back-end that follows the module docstring example (
ep = metadata.entrypoints.copy(); ep["console_scripts"] = metadata.scripts) then silently drops these entry points. flit_core already rejects them ("Scripts should be specified in [project.scripts] or [project.gui-scripts]…").This adds the check to the existing
project.entry-pointskey validator, next to the group name check. Each of the two groups produces aConfigurationErrorthat points toproject.scripts/project.gui-scripts, and is collected like the other errors whenall_errors=True.Three existing tests used
console_scriptsonly as an example group name, for a type error and for the PEP 808 dual-dynamic case. I renamed it tosome_groupthere, since those tests are about other behavior.Tests: two new
test_loadcases ("console_scripts in entry-points", "gui_scripts in entry-points") fail without the change. The full suite passes (410 passed, 115 skipped), as doruff checkandruff format --check.mypyreports the same four import-related errors in the test files as onmainin my environment.