Fix MLX advanced indexing and support boolean masks - #2402
Open
jessegrabowski wants to merge 5 commits into
Open
Fix MLX advanced indexing and support boolean masks#2402jessegrabowski wants to merge 5 commits into
jessegrabowski wants to merge 5 commits into
Conversation
jessegrabowski
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdvancedIncSubtensordropped the slices inop.idx_list, sox[:, idx] = ywrote down the leading axis. Separate bug in the same dispatches: slice bounds arrived as MLX arrays, sox[idx, 1:4]raised.Boolean masks work now: existing rewrites tagged for mlx, plus a
Nonzerodispatch.Two of those rewrites moved from position 100 to 1.95 to run ahead of
specialize, which changes JAX's ordering too.Runtime masks can't be traced, so
MLXLinkerruns any graph containingNonzerouncompiled and warns.Closes #2387