Skip to content

Provide stdlib::ensure_resource(s) functions - #1450

Open
dlucredativ wants to merge 2 commits into
puppetlabs:mainfrom
dlucredativ:ensure_resources_v4
Open

Provide stdlib::ensure_resource(s) functions#1450
dlucredativ wants to merge 2 commits into
puppetlabs:mainfrom
dlucredativ:ensure_resources_v4

Conversation

@dlucredativ

@dlucredativ dlucredativ commented Feb 28, 2025

Copy link
Copy Markdown

This PR translates legacy defined_with_params and ensure_resource(s) functions to namespaced v4 functions.

@CLAassistant

CLAassistant commented Feb 28, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jst-cyr

jst-cyr commented Jul 27, 2026

Copy link
Copy Markdown
Member

@dlucredativ : Thanks for the PR! I'm looking at prioritizing review by the team and would love some help understanding what issue you were having that brought about these changes? Can you explain a little about the 'why' behind adding the namespaced functions?

@dlucredativ

dlucredativ commented Jul 28, 2026

Copy link
Copy Markdown
Author

@dlucredativ : Thanks for the PR! I'm looking at prioritizing review by the team and would love some help understanding what issue you were having that brought about these changes? Can you explain a little about the 'why' behind adding the namespaced functions?

I don't have a specific issue, but I was under the impression that stdlib gradually deprecates legacy API functions, e.g. because of https://help.puppet.com/core/8/Content/PuppetCore/env_troubleshoot_leakage.htm

b4ldr
b4ldr approved these changes Aug 4, 2026
View reviewed changes

@b4ldr b4ldr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/puppet/functions/stdlib/defined_with_params.rb
params = {} if params == ''
ret = false

if Puppet::Util::Package.versioncmp(Puppet.version, '4.6.0') >= 0

@b4ldr b4ldr Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hope we can drop this test now 4.6.0 is long since dead

@jst-cyr
jst-cyr force-pushed the ensure_resources_v4 branch from 4a21768 to df250eb Compare August 15, 2026 02:22
@jst-cyr jst-cyr mentioned this pull request Aug 15, 2026
Closed
@jst-cyr

jst-cyr commented Aug 15, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR here: #1489

@jst-cyr

jst-cyr commented Aug 15, 2026

Copy link
Copy Markdown
Member

CI results are in via #1489. The only red platform (SLES-12) fails while provisioning the test VM, not in the acceptance tests themselves, and it fails the same way on main today with the nightly tests. All other platforms are green. No new or different failures were introduced by this PR. 👍

Still needs engineering review, but acceptance testing looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b4ldr b4ldr b4ldr approved these changes
@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner
@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner
@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner
@smortex smortex Awaiting requested review from smortex smortex is a code owner
@seanmil seanmil Awaiting requested review from seanmil seanmil is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlucredativ @CLAassistant @jst-cyr @b4ldr