Repository navigation
clean up most OptionalExtensionNotSupported - #340
Merged
Merged
Conversation
Owner
Ok, but with an extra step: we fix specs to be MAY in the first case and SHOULD in the second case; and then make irctest use either OptionalBehaviorNotSupported or unittest.SkipTest/xfail based on that
According to https://dashboard.irctest.limnoria.net/irctest.server_tests.whowas.xhtml , none.
can't we remove that? |
progval
reviewed
Feb 8, 2026
Co-authored-by: Val Lorentz <progval+github@progval.net>
slingamn
added a commit
to slingamn/irctest
that referenced
this pull request
Feb 9, 2026
This is a bug in progval#340. If we pass reason.value instead of reason to the unittest.SkipTest constructor, pytest_runtest_call will never see the exception argument as an element of self.controller.optional_behaviors, resulting in the test being skipped even when it shouldn't.
slingamn
added a commit
that referenced
this pull request
Feb 9, 2026
This is a bug in #340. If we pass reason.value instead of reason to the unittest.SkipTest constructor, pytest_runtest_call will never see the exception argument as an element of self.controller.optional_behaviors, resulting in the test being skipped even when it shouldn't be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug in #336 where it raised
OptionalExtensionNotSupported(which is unchecked) instead ofOptionalBehaviorNotSupported(which takes an enum and is checked against the controller's set of supported optional behaviors).I think ultimately we should get rid of
OptionalExtensionNotSupportedbecause of its potential for confusion. The strategy here is:OptionalBehaviorsenum for it and useOptionalBehaviorNotSupportedunittest.SkipTestSome cases I couldn't figure out:
irctest/server_tests/list.py(but here I would lean towards biting the bullet and creating separate enums for, e.g.ELIST_M,ELIST_U).testDoubleKickMessageshas an exception for ircds that don't automatically op the channel creator; I think this behavior is weird enough that we should explicitly exempt those ircds by controller name