Move reference results metadata into each archive#882
Open
PranjalManhgaye wants to merge 2 commits into
Open
Conversation
Store generation metadata inside each archive's case directory instead of writing one shared file per tutorial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
store
reference_results.metadatainside each archive's case directorystop writing one shared metadata file per tutorial
ignore the embedded metadata during field comparison
update the system-test documentation
Closes #811
Test Plan
Packed sample archives locally and verified
reference_results.metadataends up inside each case folder, with exports anditeration logsunchanged, and no shared metadata file written anymore. Also verified fieldcompare ignores the metadata file, andran pre-commiton the changed files. Full regeneration of reference archives happens after merge, as discussed.