Repository navigation
Remove restrictions of the scipy version - #211
Merged
Merged
Conversation
MakisH
changed the title
Member
Author
|
The CI passes. In the system tests, all cases but one succeed. The failing one shows some regressions, for which I don't think we can do anything: https://github.com/precice/fenics-adapter/actions/runs/36131577383 I would just update the reference results after merging this one. @IshaanDesai ok? |
MakisH
marked this pull request as ready for review
October 1, 2026 12:53
IshaanDesai
approved these changes
Oct 1, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
Assuming you looked at the result visually and it looks reasonable, I have no objections to updating the reference results.
Member
Author
|
Yes, I looked at the visual diffs at the interface (at the bottom of the test run), and at the full results: 
|
This was referenced Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #195 (comment), testing in the CI.
Related to precice/tutorials#887