Skip to content

Replicate Orlando's adapter schema changes plus a fix - #5

Merged
MakisH merged 1 commit into
mainfrom
replicate-orlando-changes
Oct 1, 2026
Merged

MakisH merged 1 commit into
mainfrom
replicate-orlando-changes

Conversation

@Logende

@Logende Logende commented Oct 1, 2026

Copy link
Copy Markdown
Member

Replicate Orlando's adapter schema changes plus a fix.

Original change by Orlando on other repo: precice/preeco-orga@68cc53b

The copy of the adapter schema on this other repo will be removed after this PR is merged.

Replicate Orlando's adapter schema changes plus a fix
@MakisH

MakisH commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Note that the link in the R10 adapter guideline will need to be updated as well: https://precice.org/community-guidelines-adapters.html

When migrating commits, I would suggest cherry-picking (related histories) or git-filter-repo (for unrelated histories), to maintain the history and contributors. In this PR, a co-authored-by: would be good practice (e.g., in the final merge commit message).

@MakisH MakisH left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks identical to precice/preeco-orga@68cc53b + a missing location.

@Logende

Logende commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Note that the link in the R10 adapter guideline will need to be updated as well: https://precice.org/community-guidelines-adapters.html

When migrating commits, I would suggest cherry-picking (related histories) or git-filter-repo (for unrelated histories), to maintain the history and contributors. In this PR, a co-authored-by: would be good practice (e.g., in the final merge commit message).

Due to unrelated histories + different file-paths I am not sure if cherry-picking or git-filter-repo would have worked.

@MakisH feel free to merge and add co-authored-by: to the final merge commit message :) I am not fully sure about the positioning of that text.

@IshaanDesai IshaanDesai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification has no effect when the schema is used to validate the Micro Manager configuration.

@MakisH
MakisH merged commit 67f2a0d into main Oct 1, 2026
1 check passed
@MakisH
MakisH deleted the replicate-orlando-changes branch October 1, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants