Skip to content

Extend adapter config schema by solver specific option for object and array values - #3

Merged
Logende merged 2 commits into
mainfrom
extend-adapter-config-schema-solver-specific-options
Sep 30, 2026
Merged

Logende merged 2 commits into
mainfrom
extend-adapter-config-schema-solver-specific-options

Conversation

@Logende

@Logende Logende commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

This enables the config desired for the Micro Manager (precice/preeco-orga#78 (comment))

E.g.,

{
   "participant_name": "Fluid",
   "precice_config_file_path": "../precice-config.xml",
   "interfaces": [
      {
         "mesh_name": "Fluid-Mesh"
      }
   ],
   "micro_manager": {
      "micro_file_names": [
         "python/micro.py"
      ],
      "coupling_params": {
         "precice_config_file_name": "precice-config.xml",
         "macro_mesh_name": "Macro-Mesh",
         "read_data_names": [
            "Macro-Scalar",
            "Macro-Vector"
         ],
         "write_data_names": [
            "Micro-Scalar",
            "Micro-Vector"
         ]
      },
      "simulation_params": {
         "micro_dt": 1,
         "macro_domain_bounds": [
            0,
            1,
            0,
            1,
            0,
            1
         ]
      }
   }
}

Comment thread preciceadapterschema/precice_adapter_config.schema.json
@MakisH

MakisH commented Sep 30, 2026

Copy link
Copy Markdown
Member

Nice! If this works for @IshaanDesai, I have nothing to add.

@IshaanDesai

Copy link
Copy Markdown
Member

Thanks for the quick PR! I will test this by pulling the schema from this branch and validating the Micro Manager configuration after conforming it. Let me prepare a PR and then report back.

@IshaanDesai

Copy link
Copy Markdown
Member

The changes to the schema are sufficient to conform the Micro Manager configuration to it, as shown in precice/micro-manager#324

@IshaanDesai IshaanDesai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently pointing to this branch when getting the schema via the PyPI package. Once we merge this, it would be good to release so I can remove the hardcoding of the branch name.

@Logende
Logende merged commit 9b24766 into main Sep 30, 2026
1 check passed
@IshaanDesai
IshaanDesai deleted the extend-adapter-config-schema-solver-specific-options branch September 30, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants