Repository navigation
Extend adapter config schema by solver specific option for object and array values - #3
Merged
Logende merged 2 commits intoSep 30, 2026
Conversation
Logende
commented
Sep 29, 2026
Member
|
Nice! If this works for @IshaanDesai, I have nothing to add. |
Member
|
Thanks for the quick PR! I will test this by pulling the schema from this branch and validating the Micro Manager configuration after conforming it. Let me prepare a PR and then report back. |
Member
|
The changes to the schema are sufficient to conform the Micro Manager configuration to it, as shown in precice/micro-manager#324 |
MakisH
approved these changes
Sep 30, 2026
IshaanDesai
approved these changes
Sep 30, 2026
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
I am currently pointing to this branch when getting the schema via the PyPI package. Once we merge this, it would be good to release so I can remove the hardcoding of the branch name.
IshaanDesai
deleted the
extend-adapter-config-schema-solver-specific-options
branch
September 30, 2026 20:43
uekerman
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the config desired for the Micro Manager (precice/preeco-orga#78 (comment))
E.g.,