Pods 3.3.10 - #7553
Conversation
c1e5cae to
9dcdebc
Compare
There was a problem hiding this comment.
Pull request overview
Release-prep changes for the Pods 3.3.10 pre-release, including a fix to Whatsit::count_groups() and associated version/dependency/workflow updates.
Changes:
- Fix
Whatsit::count_groups()to reliably return an integer when cached groups are present. - Bump plugin/package versions and update changelog for 3.3.10.
- Refresh dev dependencies and GitHub Actions workflow action versions.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Pods/Whatsit.php |
Fixes count_groups() cached-return behavior to match its int contract. |
readme.txt |
Updates stable tag and adds a 3.3.10 changelog entry. |
package.json |
Bumps package version to 3.3.10-a-1. |
init.php |
Bumps plugin header version and PODS_VERSION constant to 3.3.10-a-1. |
composer.json |
Updates dev dependencies and adds the wp-packages Composer repository. |
.github/workflows/tests-php.yml |
Updates workflow action versions used by the PHP test pipeline. |
Files not reviewed (1)
- src/Pods/Whatsit.php: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "stellarwp/coding-standards": "dev-main", | ||
| "symfony/console": "^7.4", | ||
| "szepeviktor/phpstan-wordpress": "^v1.3", |
|
|
||
| == Changelog == | ||
|
|
||
| = 3.3.10 - June 8th, 2026 = |
|
|
||
| if ( null !== $this->_groups && ! $has_custom_args ) { | ||
| return $this->_groups; | ||
| return count( $this->_groups ); | ||
| } |
e019acf to
b98e645
Compare
…d in some circumstances Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Refactor is_empty method to use pods_trim and improve empty value checks. Resolves issues with PHP trim() issues with non-strings. Also supporting multiple date values in is_empty(). Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
This fixes issues with PHP string juggling on functions that can't take nulls. Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
b98e645 to
21e6519
Compare
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
PR Summary
|
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Automated changes by create-pull-request GitHub action