Skip to content

Pods 3.3.10 - #7553

Open
PodsBot wants to merge 14 commits into
mainfrom
release/3.3.10
Open

Pods 3.3.10#7553
PodsBot wants to merge 14 commits into
mainfrom
release/3.3.10

Conversation

@PodsBot

@PodsBot PodsBot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Automated changes by create-pull-request GitHub action

@sc0ttkclark
sc0ttkclark force-pushed the release/3.3.10 branch 2 times, most recently from c1e5cae to 9dcdebc Compare June 8, 2026 04:04
@sc0ttkclark
sc0ttkclark marked this pull request as ready for review July 23, 2026 15:03
Copilot AI review requested due to automatic review settings July 23, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release-prep changes for the Pods 3.3.10 pre-release, including a fix to Whatsit::count_groups() and associated version/dependency/workflow updates.

Changes:

  • Fix Whatsit::count_groups() to reliably return an integer when cached groups are present.
  • Bump plugin/package versions and update changelog for 3.3.10.
  • Refresh dev dependencies and GitHub Actions workflow action versions.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Pods/Whatsit.php Fixes count_groups() cached-return behavior to match its int contract.
readme.txt Updates stable tag and adds a 3.3.10 changelog entry.
package.json Bumps package version to 3.3.10-a-1.
init.php Bumps plugin header version and PODS_VERSION constant to 3.3.10-a-1.
composer.json Updates dev dependencies and adds the wp-packages Composer repository.
.github/workflows/tests-php.yml Updates workflow action versions used by the PHP test pipeline.
Files not reviewed (1)
  • src/Pods/Whatsit.php: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread composer.json
Comment on lines 71 to 73
"stellarwp/coding-standards": "dev-main",
"symfony/console": "^7.4",
"szepeviktor/phpstan-wordpress": "^v1.3",
Comment thread readme.txt Outdated

== Changelog ==

= 3.3.10 - June 8th, 2026 =
Comment thread src/Pods/Whatsit.php
Comment on lines 1388 to 1391

if ( null !== $this->_groups && ! $has_custom_args ) {
return $this->_groups;
return count( $this->_groups );
}
@sc0ttkclark
sc0ttkclark force-pushed the release/3.3.10 branch 2 times, most recently from e019acf to b98e645 Compare August 14, 2026 16:43
sc0ttkclark and others added 8 commits August 14, 2026 17:11
…d in some circumstances

Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Refactor is_empty method to use pods_trim and improve empty value checks.

Resolves issues with PHP trim() issues with non-strings.

Also supporting multiple date values in is_empty().

Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
This fixes issues with PHP string juggling on functions that can't take nulls.

Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
Signed-off-by: Scott Kingsley Clark <lol@scottkclark.com>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
@what-the-diff

what-the-diff Bot commented Aug 30, 2026

Copy link
Copy Markdown

PR Summary

  • Standardized Typecasting Across Files
    Updated typecasting from (boolean) to (bool) in various files to enhance consistency.

  • Updated Method for Table Name Replacement in PodsData.php
    Added a new method to replace wp_users and similar tables with their respective database table variables for better versatility.

  • Is_empty Method Enhancement in datetime.php
    Improved the is_empty method to properly handle array inputs, enhancing its robustness.

  • AJAX Attachment Handling Improvement in file.php
    Enhanced AJAX attachment handling for better clarity and improved filtering capability.

  • Project Version Update
    Updated the version number from 3.3.9.1 to 3.3.10-a-2 in init.php, package.json, and readme.txt.

  • Return Value Correction in count_groups Method
    Corrected the return value in the count_groups method of Whatsit.php to return the count of groups instead of the groups array itself for better data accuracy.

  • Progress Status Adjustment in PodsUpgrade.php
    Adjusted PodsUpgrade.php to ensure 'progress' status is correctly set as a boolean, preventing any data inconsistency.

  • Modification of Hardcoded Values in Form Handling
    Replaced hardcoded values in the form handling with proper boolean casting, ensuring the correct type of data is processed.

Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Signed-off-by: Scott Kingsley Clark <scott@skc.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants