Fix phantom sampler binding for a trailing texture in WGSL reflection - #9198
Merged
Conversation
Co-authored-by: SashaRX <alexander.komendant@spistudios.com>
3 tasks
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WGSL reflection fabricated a sampler binding for a texture declared as the last resource in a shader:
resources[i + 1]isundefined, sohasSamplerended upundefinedand fell through toBindTextureFormat'shasSampler = truedefault — adding a phantom sampler slot to the bind group layout and emitting an unused${name}_samplerdeclaration.Extracted from #9167 (thanks @SashaRX for spotting this) so the fix can land independently.
Changes:
WebgpuShaderProcessorWGSL:hasSamplerdefaults tofalsewhen no resource follows the texture (?? false).texture_2d<f32>reflects withhasSampler: false, a single slot, and no fabricated sampler declaration.