[2290] Adding disk detach path on keep sata option

[meghansh-pf9]

What this PR does / why we need it

Answering the LDM boot gate with "Keep on SATA" left the 1 GB virtio probe disk
attached, relying on delete_on_termination — which only fires when the instance is
eventually deleted, so it lingered for the life of the VM. It is now hot-detached and
deleted. Safe while running: the probe is a raw, unformatted disk and viostor stays
in the DriverStore whether or not the device is present.

Needs two server-scoped OpenStack operations. DetachVolumeFromVM and WaitForVolume
resolve the instance via GetCurrentInstanceUUID — the vJailbreak appliance, not the
migrated VM — so they detach from the wrong server and then wait on an attachment that
is never theirs to release.

Best effort, bounded at 2 minutes: a guest that never loaded viostor may not
acknowledge the unplug, which is usually why "Keep on SATA" was chosen. On expiry the
probe stays attached as before.

fixes #2290

Testing Done

[github-actions]

🚨 Security Vulnerability Summary

Security posture degraded

📊 Overall Changes

Metric	Count
Total Added	4
Total Fixed	0
Net Change	+4

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current	Baseline	Added	Fixed	Method
0	0	0	0	artifact

📦 Trivy (Dependency Scan)

Current	Baseline	Added	Fixed	Method
90	86	4	0	artifact

📋 Baseline Methods

• 📦 artifact: Used stored report from main branch
• 🔄 live_scan: Scanned base branch in real-time
• ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

🚨 Added Vulnerabilities

Trivy (Dependencies) - 4 Added

Target: k8s/migration/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

Target: pkg/common/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

Target: pkg/vpwned/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

Target: v2v-helper/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

---

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 642e5fcc50500a271fedb5d39bf61eb08763b428

[github-actions]

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric	Count
Total Added	0
Total Fixed	0
Net Change	0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current	Baseline	Added	Fixed	Method
0	0	0	0	artifact

📦 Trivy (Dependency Scan)

Current	Baseline	Added	Fixed	Method
90	90	0	0	artifact

📋 Baseline Methods

• 📦 artifact: Used stored report from main branch
• 🔄 live_scan: Scanned base branch in real-time
• ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

---

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 95f7589b4132b07ebd3d0a69d3ba8bf361b93fe1

[spai-p9]

lgtm

[github-actions]

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric	Count
Total Added	0
Total Fixed	0
Net Change	0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current	Baseline	Added	Fixed	Method
0	0	0	0	artifact

📦 Trivy (Dependency Scan)

Current	Baseline	Added	Fixed	Method
90	90	0	0	artifact

📋 Baseline Methods

• 📦 artifact: Used stored report from main branch
• 🔄 live_scan: Scanned base branch in real-time
• ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

---

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 66b08bd311104fa130f7e8f3b1f1684ab0042268