Skip to content

[2287] Adding extra phase for transition from sata to virtio - #2293

Open
meghansh-pf9 wants to merge 1 commit into
mainfrom
private/main/megh/ldm-extraphase
Open

[2287] Adding extra phase for transition from sata to virtio#2293
meghansh-pf9 wants to merge 1 commit into
mainfrom
private/main/megh/ldm-extraphase

Conversation

@meghansh-pf9

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Answering the LDM boot gate with "Move to virtio" left the migration reporting
WaitingForLDMBootSuccess for the entire rebuild, so status.phase claimed an
operator action was outstanding while the VM was actually being stopped, deleted
and recreated. The UI showed no progress for it.

Adds a PromotingToVirtio phase covering that window. LDMGateHoldsPhase becomes
LDMHeldPhase and returns which phase is held rather than just whether one is —
same label-first logic, it simply stops collapsing the two states into one.

Surfaced as work in progress rather than a gate: "Moving to virtio" with a progress
panel, spinner instead of the pause icon, an informational banner, and no action
button. Also included in the table's active-phase set, the sidenav, and the detail
page's polling window so the rebuild keeps refreshing.

fixes #2287

Testing Done

image

@github-actions

Copy link
Copy Markdown
Contributor

🚨 Security Vulnerability Summary

Security posture degraded

📊 Overall Changes

Metric Count
Total Added 4
Total Fixed 0
Net Change +4

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
90 86 4 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

🚨 Added Vulnerabilities

Trivy (Dependencies) - 4 Added

Target: k8s/migration/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

Target: pkg/common/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

Target: pkg/vpwned/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing

Target: v2v-helper/go.mod
Package: golang.org/x/net v0.47.0
Vulnerability: CVE-2026-46600
Severity: HIGH
Title: golang.org/x/net/dns/dnsmessage: golang.org/x/net/dns/dnsmessage: Denial of Service via invalid DNS record parsing


Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 642e5fcc50500a271fedb5d39bf61eb08763b428

@meghansh-pf9
meghansh-pf9 marked this pull request as ready for review August 13, 2026 12:25
@meghansh-pf9
meghansh-pf9 requested a review from spai-p9 August 13, 2026 12:25
@meghansh-pf9
meghansh-pf9 force-pushed the private/main/megh/ldm-extraphase branch from f6883a1 to 4876a51 Compare August 13, 2026 12:34
@github-actions

Copy link
Copy Markdown
Contributor

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric Count
Total Added 0
Total Fixed 0
Net Change 0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
90 90 0 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 95f7589b4132b07ebd3d0a69d3ba8bf361b93fe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add status for move to virtio progress status in UI

1 participant