[2212] Refactoring migration scheduling and validations - #2224
Open
meghansh-pf9 wants to merge 3 commits into
Open
[2212] Refactoring migration scheduling and validations#2224meghansh-pf9 wants to merge 3 commits into
meghansh-pf9 wants to merge 3 commits into
Conversation
meghansh-pf9
force-pushed
the
private/main/megh/agent-scheduling
branch
from
July 28, 2026 12:06
6f9babb to
a1bc087
Compare
meghansh-pf9
marked this pull request as ready for review
July 28, 2026 12:06
Contributor
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
1 similar comment
Contributor
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
meghansh-pf9
enabled auto-merge (squash)
July 28, 2026 12:55
meghansh-pf9
disabled auto-merge
July 29, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
A VM with no matching OpenStack flavor used to abort the whole MigrationPlan — every VM behind it in the list never got a ConfigMap or Job, and the plan retried forever on the same VM.
Now the failure is contained to that VM:
ErrNoSuitableFlavorsentinel +errors.Isso only an unschedulable shape is treated as a skip; auth/connectivity errors still requeue. Replaces astrings.Containscheck.MigrationinValidationFailedwith an actionable reason, so it stays visible in the UI (no UI changes needed).processMigrationPhasesaccumulates per-VM failures instead of returning on the first one; the plan is markedPodFailedonly once nothing is still running, so post-migration still runs for the VMs that succeeded.Which issue(s) this PR fixes
fixes #2212
Testing Done