Use idiomatic Effect filesystem and duration APIs#3543
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
node:fs/promises.realpathwrappers inWorkspaceFileSystem.readFilewith the injected EffectFileSystem.realPathservice.PlatformErrordetails in the workspace read failure test.Effect.sleep(1000)withANALYTICS_FLUSH_INTERVAL = Duration.seconds(1).Why
This keeps production Effect code on Effect-native services and duration values, making filesystem behavior easier to layer/mock and scheduled telemetry behavior deterministic under
TestClock.UI Changes
Not applicable.
Checklist
Verification:
PATH="$HOME/.nvm/versions/node/v24.18.0/bin:$PATH" pnpm exec vp test apps/server/src/workspace/WorkspaceFileSystem.test.ts apps/server/src/telemetry/AnalyticsService.test.tsPATH="$HOME/.nvm/versions/node/v24.18.0/bin:$PATH" pnpm exec vp checkPATH="$HOME/.nvm/versions/node/v24.18.0/bin:$PATH" pnpm exec vp run typecheckNote
Use idiomatic Effect filesystem and duration APIs in
WorkspaceFileSystemandAnalyticsServiceNodeFSP.realpathwrapped inEffect.tryPromisewithFileSystem.realPathinWorkspaceFileSystem.ts; errors now map toWorkspaceFileSystemOperationErrorwith aPlatformErrorcause instead of a rawNodeJS.ErrnoException.ANALYTICS_FLUSH_INTERVALasDuration.seconds(1)inAnalyticsService.tsand replaces the hardcoded1000mssleep withEffect.sleep(ANALYTICS_FLUSH_INTERVAL).AnalyticsService.test.tsthat verifies periodic flush behavior usingTestClock.WorkspaceFileSystem.readFileerrors on path resolution now carry aPlatformErrorwithreason._tag === 'NotFound'andreason.method === 'realPath'instead of a Node errno object.Macroscope summarized 7e514b6.