[codex] fix: keep settings Escape local to edit fields

[StiensWout]

Summary

• Add a composed-path editable target guard to the settings Escape handler.
• Treat native edit fields, contenteditable textboxes, and the shared SelectTrigger as local Escape owners.
• Preserve settings back navigation when focus is outside editable controls.

Root cause

The settings route window keydown handler handled every unprevented Escape before checking whether the event came from an editable control.

Impact

Escape no longer leaves settings edit fields or closes a Base UI select trigger unexpectedly. Non-editable focus still uses the existing settings back navigation.

Validation

• PATH="$HOME/.vite-plus/bin:$PATH" vp check
• PATH="$HOME/.vite-plus/bin:$PATH" vp run typecheck

---

Note

Low Risk
Localized keyboard routing in the settings route only; no auth, data, or API changes.

Overview
Escape in settings no longer navigates away when the key is pressed while focus is inside an editable control.

SettingsContentLayout’s window-level Escape handler now bails out if the event’s composed path includes native inputs, textareas, selects, [data-slot="select-trigger"] (shared UI select), contenteditable regions, or role="textbox". A small eventPathContainsSelector helper walks event.composedPath() (with a event.target fallback) to detect those targets. Back navigation on Escape is unchanged when focus is outside those elements.

^{Reviewed by Cursor Bugbot for commit a0f1ff3. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Escape key in settings to skip navigation when focus is within editable fields

The SettingsContentLayout keydown handler in settings.tsx previously navigated back on every Escape keypress. It now checks whether the event originated from an input, textarea, select, contenteditable, or role="textbox" element and skips navigation if so, using a new eventPathContainsSelector utility that walks event.composedPath().

^{Macroscope summarized a0f1ff3.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf3d4954-36c6-4a48-9ea9-e7fb092a1bb7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved

Small, self-contained bug fix that prevents the Escape key from navigating away when typing in editable fields. The change adds a straightforward guard condition with clear intent and no side effects.

^{You can customize Macroscope's approvability policy. Learn more.}