Skip to content

[codex] Fix provider update checks restore defaults#3531

Open
StiensWout wants to merge 1 commit into
pingdotgg:mainfrom
StiensWout:staging/provider-update-restore
Open

[codex] Fix provider update checks restore defaults#3531
StiensWout wants to merge 1 commit into
pingdotgg:mainfrom
StiensWout:staging/provider-update-restore

Conversation

@StiensWout

@StiensWout StiensWout commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restores provider update checks through the global settings Restore defaults action.
  • Includes Provider update checks in the confirmation list when it differs from the default.

Root cause

The global Restore defaults hook reset assistant streaming but skipped enableProviderUpdateChecks, even though the row-level Provider update checks setting already supported reset.

Impact

Users who change Provider update checks can restore it to the default through the global settings action along with other global settings.

Validation

  • PATH="$HOME/.vite-plus/bin:$PATH" vp check passes with existing unrelated lint warnings.
  • PATH="$HOME/.vite-plus/bin:$PATH" vp run typecheck passes.

Note

Low Risk
Small settings-hook change with no auth, security, or data-path impact.

Overview
Fixes a gap in useSettingsRestore: Provider update checks (enableProviderUpdateChecks) now behaves like other general settings when using Restore defaults.

When the value differs from DEFAULT_UNIFIED_SETTINGS, Provider update checks appears in the reset confirmation list. Confirming restore also writes the default back via updateSettings, matching the per-row reset on the General settings panel.

Reviewed by Cursor Bugbot for commit deaaaf6. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix enableProviderUpdateChecks to be tracked and restored by useSettingsRestore

The useSettingsRestore hook in SettingsPanels.tsx was not handling the enableProviderUpdateChecks setting. This adds it to the changed-settings label computation and includes it in the restoreDefaults payload so it resets to DEFAULT_UNIFIED_SETTINGS.enableProviderUpdateChecks.

Macroscope summarized deaaaf6.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6af6e7c9-ef11-4d3d-9738-d7d2830a04f2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jun 23, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Simple bug fix that adds the missing enableProviderUpdateChecks setting to the restore defaults functionality. The change follows the exact same pattern used for all other settings in the file, with minimal and clearly scoped impact.

You can customize Macroscope's approvability policy. Learn more.

Co-authored-by: Codex <codex@openai.com>
@StiensWout StiensWout force-pushed the staging/provider-update-restore branch from ff6a58d to deaaaf6 Compare June 23, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant