[codex] Fix provider update checks restore defaults#3531
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Simple bug fix that adds the missing You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: Codex <codex@openai.com>
ff6a58d to
deaaaf6
Compare
Summary
Root cause
The global Restore defaults hook reset assistant streaming but skipped
enableProviderUpdateChecks, even though the row-level Provider update checks setting already supported reset.Impact
Users who change Provider update checks can restore it to the default through the global settings action along with other global settings.
Validation
PATH="$HOME/.vite-plus/bin:$PATH" vp checkpasses with existing unrelated lint warnings.PATH="$HOME/.vite-plus/bin:$PATH" vp run typecheckpasses.Note
Low Risk
Small settings-hook change with no auth, security, or data-path impact.
Overview
Fixes a gap in
useSettingsRestore: Provider update checks (enableProviderUpdateChecks) now behaves like other general settings when using Restore defaults.When the value differs from
DEFAULT_UNIFIED_SETTINGS, Provider update checks appears in the reset confirmation list. Confirming restore also writes the default back viaupdateSettings, matching the per-row reset on the General settings panel.Reviewed by Cursor Bugbot for commit deaaaf6. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
enableProviderUpdateChecksto be tracked and restored byuseSettingsRestoreThe
useSettingsRestorehook in SettingsPanels.tsx was not handling theenableProviderUpdateCheckssetting. This adds it to the changed-settings label computation and includes it in therestoreDefaultspayload so it resets toDEFAULT_UNIFIED_SETTINGS.enableProviderUpdateChecks.Macroscope summarized deaaaf6.