[codex] fix: sync provider environment rows

[StiensWout]

Summary

• Sync provider environment draft rows when persisted environment content changes while the settings card stays mounted.
• Add focused unit coverage for the persisted environment content key.

Root cause

• ProviderEnvironmentSection initialized local rows from props once and did not reconcile them when refreshed or reset provider environment props changed underneath the mounted card.
• Array identity alone is not a safe signal because callers may pass fresh empty arrays on unrelated renders.

Impact

• Provider environment rows now refresh after external settings reset or refresh without wiping local draft rows on unrelated renders.
• The existing publish behavior is preserved: invalid non-empty rows block publish, and blank default rows are skipped.

Validation

• PATH="$HOME/.vite-plus/bin:$PATH" vp test run apps/web/src/components/settings/ProviderInstanceCard.test.ts --project unit reports no configured project named unit in this checkout before running tests.
• PATH="$HOME/.vite-plus/bin:$PATH" vp test run apps/web/src/components/settings/ProviderInstanceCard.test.ts passes: 1 file, 5 tests.
• PATH="$HOME/.vite-plus/bin:$PATH" vp check passes with existing warnings outside this change.
• PATH="$HOME/.vite-plus/bin:$PATH" vp run typecheck passes.

---

Note

Medium Risk
Non-trivial client state around sensitive environment variables; regressions could drop edits, resurrect deleted rows, or mishandle redacted secret UX, though server persistence is unchanged.

Overview
Fixes provider environment variable rows going stale when persisted settings refresh or reset while the settings card stays mounted, without treating new array references as real data changes.

ProviderEnvironmentSection now keys sync off getProviderEnvironmentContentKey (serialized name/value/sensitive/redaction) and runs mergeEnvironmentDraftRowsForPersistedUpdate in a useEffect so incoming persisted snapshots merge with local drafts instead of replacing them blindly.

The merge keeps in-progress edits and blank “add” rows, honors local deletions (including stale server echoes via a locally-deleted map), handles reordering, and treats redacted sensitive save echoes as acknowledged when they match what was just published. Edits clear redaction on value change; deletes record removed variables before publish.

Adds broad unit coverage for the content key and merge edge cases in ProviderInstanceCard.test.ts.

^{Reviewed by Cursor Bugbot for commit 1d42fee. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix provider environment variable sync to preserve local edits across persisted updates

• Adds mergeEnvironmentDraftRowsForPersistedUpdate in ProviderInstanceCard.tsx to merge incoming persisted environment updates with local draft rows, preserving in-progress edits, unpublished adds, and local deletions.
• Handles sensitive variable acknowledgement: when the server echoes a redacted empty value, the UI recognizes the save as confirmed rather than overwriting local state.
• Tracks locally deleted variables so stale server echoes or conflicting re-adds don't resurrect removed rows.
• Adds getProviderEnvironmentContentKey to detect when the persisted environment has actually changed content, gating the merge effect.
• Extends the test suite in ProviderInstanceCard.test.ts with coverage for key stability, redaction semantics, reordering, and conflict resolution.

^{Macroscope summarized 1d42fee.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d643adcc-fa7b-4bb4-b9e1-943031f43619

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff7bac007e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[macroscopeapp]

Approvability

Verdict: Needs human review

Introduces substantial new state synchronization logic (~245 lines) for merging local environment variable drafts with server-persisted data. The complex state management with multiple edge cases warrants human review despite comprehensive test coverage.

^{You can customize Macroscope's approvability policy. Learn more.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6298d9fb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Dismissing prior approval to re-evaluate 9787cea

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9787cea601

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Dismissing prior approval to re-evaluate 72c7478

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8f7b869. Configure here.}