Skip to content

chore(monitor-snapshot/master): update files from upstreams - #1255

Merged
ti-chi-bot[bot] merged 1 commit into
masterfrom
fix/master/update-snapshot-files
Nov 6, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
masterfrom
fix/master/update-snapshot-files

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Auto generated by bot periodics.

Summary by CodeRabbit

  • New Features
    • Added an MV Refresh Duration graph to the Materialized View dashboard, showing refresh and scheduling durations for successful and failed operations.

@ti-chi-bot
ti-chi-bot Bot requested a review from liubog2008 November 6, 2026 09:02
@ti-chi-bot

ti-chi-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liubog2008 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/L label Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Materialized View dashboard gains an “MV Refresh Duration” graph. It shows P999 and average durations for successful and failed refresh operations, plus refresh-schedule durations, using 1-minute Prometheus rates.

Changes: MV Refresh Duration

Layer / File(s) Summary
Add MV refresh duration panel
monitor-snapshot/master/operator/dashboards/tidb.json
The dashboard adds P999 and average duration queries for successful and failed MV refreshes, plus P999 and average refresh-schedule duration queries.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested labels: size/L

Suggested reviewers: liubog2008

Merge Risk: Minimal · up to c40d0

No merge-blocking issue is identified for the MV Refresh Duration panel; merge after normal validation.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the upstream snapshot update. It is broad but relates to the dashboard change.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit watches metrics glow,
Refresh times rise and flow.
P999 and averages appear,
Success and failure both draw near.
Schedule durations join the view,
One-minute rates complete the queue.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7ae7de04-06b6-4b33-ba16-7473a5c7f29d
Commits

Reviewing files that changed from the base of the PR and between f00ea8d and c40d0aa.

Files ignored due to path filters: 1

  • monitor-snapshot/master/ansible-monitor.tar.gz is excluded by !**/*.gz
Files selected for processing: 1

  • monitor-snapshot/master/operator/dashboards/tidb.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ti-chi-bot
ti-chi-bot Bot merged commit 85f3384 into master Nov 6, 2026
5 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the fix/master/update-snapshot-files branch November 6, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant