Conversation
Codacy's Analysis Summary12 new issues (≤ 0 high issue) Review Pull Request in Codacy →
|
|
| public function locateDaoClass(string $modelClass): ?string; | ||
|
|
||
| // BC-Break: This method will be introduced in v4.0.0 | ||
| // public function getGetInheritedProperties(): bool; |
There was a problem hiding this comment.
Symfony adds such new methods to the class as PHPDoc via @method bool getGetInheritedProperties().
This way, they are recognized by the IDE, PHPStan, etc.
There was a problem hiding this comment.
ahh perfect! Thank you for the tip
i was thinking and looking for something like this to be consistent and aligned to Symfony too.
There was a problem hiding this comment.
but doesn't it gives a false impression the method already exists (eg. like a magic method)? i was afraid that Phpstan would complain about it
There was a problem hiding this comment.
also considered a @deprecation to use interface without the mentioned methods or so, but without a replacement, seems improper to use it
|
Closing, as there won't be any minor release anymore, just a major without anticipation or warn about the upcoming BC-break |
3 participants
Changes in this pull request
Related #124
Part of #118
Additional info