Repository navigation
Conversation
…ntracked expression
dg
force-pushed
the
fix-extension-narrowing
branch
2 times, most recently
from
October 6, 2026 14:10
e3183d3 to
612b71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2.3, narrowing reads an expression's current type through
MutatingScope::resolveScopeStateType(), which derives a property fetch's type from property reflection and skipsExpressionTypeResolverExtensions. For a property that only an extension knows (e.g. a@property-readtag on an interface, whichClassReflectionignores without__get), reflection finds nothing, so the narrowing starts fromErrorType:In 2.2
removeTypeFromExpression()started fromgetType(), which asks the extensions first. This makes the state read of an untracked expression ask them the same wayresolveType()does; a tracked (already narrowed) type still wins without asking them.