feat: warn when single-out version is absent from filtered list#38
feat: warn when single-out version is absent from filtered list#38Koan-Bot wants to merge 3 commits into
Conversation
When single-out resolves to a version not present in the filtered perl-versions list (e.g. single-out=5.20 with since-perl=5.30), emit a core.warning() so users get early feedback instead of silent downstream CI failures from missing Docker images. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
We need to rebuild |
|
@Koan-Bot rebase |
|
Purpose of |
|
Warning behaviour should be configurable, see comment Related to #39 (comment) |
Rebase: feat: warn when single-out version is absent from filtered listBranch Actions
Automated by Kōan |
| const msg = | ||
| `single-out version '${single_out}' is not in the filtered perl-versions list. ` + | ||
| `This may cause downstream CI failures if no Docker image exists for this version.`; | ||
| if (on_missing === 'error') { |
There was a problem hiding this comment.
favour switch/case over chained if/else if
This behaviour deserves function, may be shared by other features.
Message is valid only of one target - perl-tester. Other targets may not use docker at all.
Rebase: feat: warn when single-out version is absent from filtered listBranch Diff: 7 files changed, 19199 insertions(+), 22502 deletions(-) Review feedback was analyzed and applied. Actions
Automated by Kōan |
3 participants
What
Emits a
core.warning()whensingle-outresolves to a version not present in the filtered perl-versions list.Why
When a user sets
single-out: 5.20but theirsince-perlfilter excludes it (e.g.since-perl: 5.30), the action silently passes through the version. Downstream CI then fails trying to pull a Docker image for a version that was never in the matrix — with no hint about why.How
A simple
filtered.includes(single_out)check inindex.jsafterresolve_single_out()returns. The warning message names the version and explains the risk. No behavior change — the version still gets returned, just with a visible warning.Testing
dist/index.jsrebuilt