Skip to content

Bugfix/showpopover error - #141

Merged
glenstaes merged 1 commit into
masterfrom
bugfix/showpopover-error
Aug 3, 2026
Merged

Bugfix/showpopover error#141
glenstaes merged 1 commit into
masterfrom
bugfix/showpopover-error

Conversation

@maaso

@maaso maaso commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Change the default cdkDrag rootElement and make it configurable

Closes #140

@maaso
maaso force-pushed the bugfix/showpopover-error branch from 001fae0 to 5fa99ca Compare July 9, 2026 14:17
hostDirectives: [CdkDrag]
})
export class DraggableDialogDirective implements OnInit {
rootElementSelector = input('mat-dialog-container', {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this public readonly.

Comment thread projects/ppwcode/ng-dialogs/src/lib/directives/draggable-dialog.directive.ts Outdated
@maaso
maaso force-pushed the bugfix/showpopover-error branch from 5fa99ca to 522bb5c Compare August 3, 2026 13:26
@glenstaes
glenstaes merged commit 33cd4eb into master Aug 3, 2026
1 check passed
@glenstaes
glenstaes deleted the bugfix/showpopover-error branch August 3, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(dialog): TypeError Cannot use 'in' operator to search for 'showPopover' in null

2 participants