Honor the NO_COLOR environment variable - #358
Open
GhostCoder6969 wants to merge 1 commit into
Open
GhostCoder6969 wants to merge 1 commit into
GhostCoder6969 wants to merge 1 commit into
Conversation
The --colorize flag no longer produces ANSI codes when NO_COLOR is present and not empty, per https://no-color.org. Fixes pemistahl#272.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #272. The --colorize flag now stays quiet when NO_COLOR is set and not empty, per the no-color.org standard. Empty NO_COLOR still colorizes, and nothing changes when the variable is absent. I added tests for all three cases plus the --help note. Let me know if you would rather handle this inside the builder instead.