Raise CaptionReadSyntaxError for malformed SRT instead of IndexError - #419
Open
eeshsaxena wants to merge 1 commit into
Open
Raise CaptionReadSyntaxError for malformed SRT instead of IndexError#419eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
SRTReader.read leaked a raw IndexError or ValueError on a few kinds of malformed input: a caption number with no timing line after it, a timing line with no --> arrow, or a timestamp with missing or non-numeric fields. read() is meant to raise the CaptionRead* errors, so callers catching those got an unexpected crash instead. Guard the timing line and wrap the timestamp parsing so these surface as CaptionReadSyntaxError, matching the other readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRTReader().read()leaks a bareIndexError(orValueError) on a few kinds of malformed SRT, rather than one of theCaptionRead*errors callers expect to catch:The first is a caption number with no timing line after it, the second a non-numeric timestamp. A timing line missing the
-->arrow, or a stamp with too few fields, hit the same paths. I guarded the timing-line lookup and wrapped the timestamp parsing so they raiseCaptionReadSyntaxErrorlike the other readers do. Added a parametrized test for the malformed cases; full suite still passes.