Repository navigation
test(frontend): finish frontend leftovers of #75, #68, #105 - #165
Merged
Merged
Conversation
The error breakdown response no longer has auto_fixed (Autofix was removed in #66); the mocks now match ErrorBreakdownResponse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
Review: #165 test(frontend): finish frontend leftovers of #75, #68, #105Diff reviewed: Blockers: none. Should-fix: none. Nits: none. Checks
Closure evidence (spot-checked at fd8339b)
The closures of #75, #68 and #105 are justified. CI on fd8339b: still running at review time. 3 of 18 runs are complete (Changeset check, Scripts, dependency-review, all success); the other 15 are Head revisado: fd8339b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the frontend leftovers of #75, #68 and #105. Backend parts landed in #153 and #157.
Changes
auto_fixedfield from the error-breakdown mocks inErrorClassCard.preserved,AnalyticsChartSurfacesandGlobalOverviewFiltertests. Noauto_fixedremains inpackages/frontend.Already done on main (verified, no change needed)
src/pages/Routing.tsx:343-347shows a catalog-sync-off toast whensync_enabled === false(mentions THINKER_CATALOG_SYNC). Covered bytests/pages/Routing.test.tsx:888-902.MessageDetails.tsx:106treatsfallback_errororsuperseded === trueas the recovered primary. Covered byMessageDetails.test.tsx:245andMessageTable.test.tsx:577.RequestHeadersPopover.tsx:35-46warns per row when a name is blocked, invalid, duplicated or over the cap, or when a value is invalid, and says the server will drop it. Covered byRequestHeadersPopover.test.tsx.playground-request-headers.ts:131-200persists only valid, non-blocked header names, never values, and migrates and removes the legacy key that stored values.Manifest/mnfsttext insrc/,public/orindex.html. The only matches are the legacy storage-key migration helpers.Tests (packages/frontend)
Test-only change, so no changeset and no runtime change.
Closes #75
Closes #68
Closes #105
🤖 Generated with Claude Code