Repository navigation
fix(providers): emit trimmed extra header names and document adapter precedence - #154
Merged
Merged
Conversation
…precedence Optional nits from the #107 review: - mergeExtraHeaders compared caller header names after trimming but emitted the untrimmed key; it now emits the trimmed name and skips blank names. - Document on ForwardOptions.extraHeaders that the adapter's headers win. Part of #105. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Full backend unit run ( |
Owner
Author
Review: #154 fix(providers): emit trimmed extra header names and document adapter precedenceReviewed Blockers: none. Should-fix: none. Checks
Head revisado: 7d8497c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #105. Items 1 to 3 already landed in #107 (adapter headers win with a case-insensitive merge, invalid values rejected,
accept/accept-encodingblocked); items 4 and 5 in #106. This PR does the optional backend nits from the #107 review.What changed
mergeExtraHeaderscompared caller header names after trimming but emitted the untrimmed key. It now emits the trimmed name, and skips a blank name. (No current caller passes padded keys; the Playground sanitizer already trims.)ForwardOptions.extraHeadersdocuments that the adapter's headers win, withanthropic-betaappended instead.The dashboard nits (shared validators, popover help text, live region reset, row warnings,
<Index>regression test) are frontend.Tests
npx jest src/routing/proxy/__tests__/extra-headers src/playground: 225 passed (3 new cases).qa-docker: not needed (no observable change for current callers).
🤖 Generated with Claude Code