[patrickbrandao]

Summary

• 30-day default retention. DEFAULT_RECORDING_RETENTION_DAYS = 30 (config/recording-retention.ts). Before this change the default was 365 days. THINKER_RECORDING_RETENTION_DAYS overrides it. A value that is not a positive integer (0, -1, 1.5, 7d, ...) fails boot with a message naming the variable, so a typo can no longer keep recordings forever.
• Rename, no aliases. The whole REQUEST_RECORDING_* family becomes THINKER_RECORDING_* in app.config.ts, the storage service error message, packages/backend/.env.example, the specs and docs/dev/manifest-guide.md. Old names are never read. If one is still set, boot logs a warning naming its replacement and never its value. This catches a stale S3 config that would otherwise fall back to the filesystem without notice.
• Boot log (RequestRecordingRetentionService.onApplicationBootstrap, after storage init): Request recordings: retention N days, storage <filesystem|s3|unavailable>.
• grep -rn "REQUEST_RECORDING_" packages finds nothing.

Not in this PR (owned by other agents, must land together)

The task scoped docker/, the deploy templates and CI out of this PR, but they still set the old names and need the same mechanical rename:

• docker/docker-compose.yml, docker/.env.example
• render.yaml, app.json, .do/deploy.template.yaml, deploy/** (fly, gcp, aws, coolify, easypanel, apple-containers, koyeb/heroku/digitalocean/aws tutorials)
• .github/workflows/docker-smoke.yml

Until they are renamed, those deployments boot with the default storage (auto) and a 30-day retention. The new warning names every ignored variable. S3-only templates (fly, aws, koyeb, heroku, DO) would fall back to filesystem storage. Do not release before the follow-up lands. The rename itself is s/REQUEST_RECORDING_/THINKER_RECORDING_/g.

Tests

• Unit: recording-retention.spec.ts (new: default 30, override, invalid values, legacy warning without values), app.config.spec.ts (default 30, override 7, invalid fails, old name ignored), request-recording-retention.service.spec.ts (30-day default, override, boot log, legacy warning).
• E2e test/request-recordings.e2e-spec.ts: with no variable set, a 31-day-old recording is deleted (object first, then pointer; the parent Request is kept) and a 29-day-old one is kept and still readable. After a restart with THINKER_RECORDING_RETENTION_DAYS=7, the 29-day-old one is deleted.

Local runs:

• npm run lint (0 errors), npm run typecheck, npm run build: pass
• npx jest (backend): 476 suites, 9097 tests passed
• TZ=UTC npm run test:e2e:docker --workspace=packages/backend: 71 suites, 600 tests passed

qa-docker: required (runtime behavior changed). Confirm the boot log line and that filesystem recording still works.

Closes #28

🤖 Generated with Claude Code

[patrickbrandao]

Review PR #148: 30-day recording retention + THINKER_RECORDING_*

Reviewed git diff origin/main...03dcf160 (12 files).

Blockers

None.

Should-fix (track before merge)

1. Deploy templates and compose still use REQUEST_RECORDING_*. Files: docker/docker-compose.yml, docker/.env.example, render.yaml, app.json, .do/deploy.template.yaml, deploy/fly/fly.toml, deploy/gcp/main.tf, deploy/easypanel/**, deploy/digitalocean/TUTORIAL.md. Scenario: someone deploys from a template after this merges. The S3 or filesystem path settings are then ignored silently, apart from the boot warning, and storage falls back to auto. Known gap. Fix in the repo-wide rename PR, and record the tracking issue link in this PR before merge.
2. Upgrade deletes older recordings. An instance on the old 365-day default loses every recording older than 30 days at the next 02:00 cron run. This is the intended decision (decisoes-iniciais §4), and docs/releases/0.1.0.md must say so explicitly, together with how to keep the old behavior (THINKER_RECORDING_RETENTION_DAYS=365). Check that it does before the release.

Nits

• packages/backend/test/request-recordings.e2e-spec.ts: the temp dir prefix manifest-recordings-e2e- is legacy (pre-existing). Rename it to thinker- in the cleanup.

Checks

• Retention: strict parsing, and an invalid value fails boot. The cron uses the value without a null fallback. e2e covers 31d/29d at the default and 7 after a restart.
• Legacy warning: logs names only, never values (unit-tested with a secret value). No credentials are logged.
• No new outbound calls, no manifest identifiers added, Conventional title, changeset present.
• No high-risk criterion: no migration, crypto, auth or tenant scoping change. The retention change applies a decision already recorded.
• CI on the SHA: all 19 check runs succeeded. qa-docker must still pass for the runtime change (merge gate).

Under aprovado, each should-fix must be fixed or tracked in an issue whose link is recorded in the PR before merge.

Head revisado: 03dcf16
Veredito: aprovado

[patrickbrandao]

Review should-fixes 1 and 2 are tracked in #152. The deploy templates are renamed in the repo-wide rename PR; the 30-day upgrade note goes into docs/releases/0.1.0.md.

[patrickbrandao]

qa-docker report

Image thinker:qa-26579 (arm64, Docker Desktop), built from docker/Dockerfile in about 4m55s, 429 MB. Bases: node:24-alpine, node:24-slim, gcr.io/distroless/nodejs24-debian13. Postgres: postgres:16-alpine. Mock provider only, THINKER_CATALOG_SYNC=false, run-scoped volumes (override with name: !reset null, labels verified, 0 left after teardown).

Step	Result
Image build	pass
Stack boot and /api/v1/health	pass (7s)
Smoke: dashboard HTML, first admin, agent key, /v1/models	pass
Chat completion: OpenAI, Anthropic (/v1/messages), Responses (/v1/responses)	pass
Backend e2e (test:e2e:docker)	pass: 71 suites, 600 tests
Gateway contracts	pass: 9/9
Check 1: boot line "Request recordings: retention 30 days, storage filesystem"	pass
Check 2: recording written to the filesystem volume (3 .json.gz files, matching recording_key rows)	pass
Check 3: THINKER_RECORDING_RETENTION_DAYS=abc	pass: exit 1, "THINKER_RECORDING_RETENTION_DAYS must be a positive integer number of days (got "abc")..."
Check 4: legacy REQUEST_RECORDING_* warning	pass: names REQUEST_RECORDING_X -> THINKER_RECORDING_X, value SUPERSECRETVAL99 never logged
Teardown	pass

Finding (should-fix, not a failure of the checks): docker/docker-compose.yml and docker/.env.example still use REQUEST_RECORDING_*. With the stock compose file the container always receives REQUEST_RECORDING_STORAGE, _FILESYSTEM_PATH and _S3_FORCE_PATH_STYLE, so every Docker boot logs the legacy warning, and a user setting REQUEST_RECORDING_RETENTION_DAYS in .env is silently ignored (with only the legacy warning in the logs). Recordings still landed on the mounted volume, so default storage works. Update compose and .env.example to THINKER_RECORDING_* in this PR or in a ticketed follow-up.

Other notes: nothing flaky. A Better Auth "Database schema mismatch" line appears once at first boot, before migrations. Not related to this PR.

Tested SHA: 03dcf16