Skip to content

fix: avoid debuginfo startup blocking and retain Go labels - #3257

Merged
brancz merged 1 commit into
mainfrom
dat-339-operator-integration
Oct 28, 2026
Merged

brancz merged 1 commit into
mainfrom
dat-339-operator-integration

Conversation

@brancz

@brancz brancz commented Oct 28, 2026

Copy link
Copy Markdown
Member

Use a lazy, reconnecting connection for an explicit --debuginfo-address so an unavailable symbols service does not block tracer startup, while retaining independent credentials, TLS, headers, RPC deadlines, and shutdown cleanup.

Keep requested Go goroutine labels and native custom labels enabled without local Go symbolization, and retain symbolization as an explicit go/all plus --symbolize-go opt-in.
Sampling flags and the profiler dependency are unchanged.

Regression tests cover tracer selection, native-frame preservation using the real Go loader, connection startup/restart/shutdown, and separate connection settings.
GOWORK=off go test -p 2 ./... -count=1 and race tests for the root, flags, and reporter packages pass.
Separate-process validation against the existing debuginfo proxy covered legacy single-upstream streaming and multi-upstream signed-URL uploads through outages, partial failures, and configuration replacement while synthetic OTLP profile delivery continued.
Uploads recovered after the existing five-minute cooldown, but configuration replacement can invalidate in-flight completions and is not seamless rotation.
Live CPU sampling and eBPF label extraction still require a supported privileged host because this orb kernel rejected the profiler program with tail_calls are not allowed in non-JITed programs with bpf-to-bpf calls.

Refs DAT-339.

Use a lazy, reconnecting client for a separate debuginfo endpoint while preserving its independent connection settings.

Keep requested Go goroutine labels active without enabling local Go frame symbolization. Cover tracer selection, native-frame preservation, and connection recovery with regression tests.

Refs: DAT-339
Amp-Thread-ID: https://ampcode.com/threads/T-7bb7c71f-b7c8-4e34-9555-439e8dfcf551
Co-authored-by: Amp <amp@ampcode.com>
@brancz
brancz merged commit 3e051a1 into main Oct 28, 2026
11 checks passed
@brancz
brancz deleted the dat-339-operator-integration branch October 28, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants