Repository navigation
fix: avoid debuginfo startup blocking and retain Go labels - #3257
Merged
Merged
Conversation
Use a lazy, reconnecting client for a separate debuginfo endpoint while preserving its independent connection settings. Keep requested Go goroutine labels active without enabling local Go frame symbolization. Cover tracer selection, native-frame preservation, and connection recovery with regression tests. Refs: DAT-339 Amp-Thread-ID: https://ampcode.com/threads/T-7bb7c71f-b7c8-4e34-9555-439e8dfcf551 Co-authored-by: Amp <amp@ampcode.com>
gnurizen
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a lazy, reconnecting connection for an explicit
--debuginfo-addressso an unavailable symbols service does not block tracer startup, while retaining independent credentials, TLS, headers, RPC deadlines, and shutdown cleanup.Keep requested Go goroutine labels and native custom labels enabled without local Go symbolization, and retain symbolization as an explicit
go/allplus--symbolize-goopt-in.Sampling flags and the profiler dependency are unchanged.
Regression tests cover tracer selection, native-frame preservation using the real Go loader, connection startup/restart/shutdown, and separate connection settings.
GOWORK=off go test -p 2 ./... -count=1and race tests for the root, flags, and reporter packages pass.Separate-process validation against the existing debuginfo proxy covered legacy single-upstream streaming and multi-upstream signed-URL uploads through outages, partial failures, and configuration replacement while synthetic OTLP profile delivery continued.
Uploads recovered after the existing five-minute cooldown, but configuration replacement can invalidate in-flight completions and is not seamless rotation.
Live CPU sampling and eBPF label extraction still require a supported privileged host because this orb kernel rejected the profiler program with
tail_calls are not allowed in non-JITed programs with bpf-to-bpf calls.Refs DAT-339.